Repository navigation
fix(redact): publish sidecar 0.2.2 with synthetic events that keep non-enumerable fields - #272
Merged
BleedingDev merged 1 commit intoOct 30, 2026
Conversation
Rsdoctor Bundle Diff Analysis📊 Quick Summary
Generated by Rsdoctor GitHub Action |
BleedingDev
force-pushed
the
fix/redact-synthetic-event-20261030
branch
from
October 30, 2026 01:30
d0c8f62 to
aaca027
Compare
…n-enumerable fields Redact copies native event fields into its synthetic events with for…in, which skips non-enumerable properties. happy-dom defines type, target, currentTarget, bubbles and composedPath as class accessors, so under happy-dom every handler saw them as undefined and controlled inputs never read e.target.value. OntOS's Shell unit tests stay on real React because of it. The reviewed patch now walks the prototype chain instead (TanStack/redact#113) in both src and dist. 0.2.1 is immutable, so the sidecar recipe and its closed profile publish it as @bleedingdev/tanstack-redact@0.2.2. The stream marker stays v1, as for any regenerated reviewed patch. The monorepo cannot install 0.2.2 before it is published, so app-tools keeps the signed 0.2.1 sidecar through an explicit previousFork edge that accepts only that exact alias, never upstream @tanstack/redact. Non-publish CI candidates and packed test cohorts install the reconstructed 0.2.2 for that edge, so every consumer suite qualifies the bytes that will ship. Release staging is never rewritten: alias consistency blocks a cohort until app-tools declares 0.2.2. The follow-up that switches app-tools deletes the edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BleedingDev
force-pushed
the
fix/redact-synthetic-event-20261030
branch
from
October 30, 2026 01:35
aaca027 to
4a15191
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
Redact's synthetic events drop
type,targetandcurrentTargetunder happy-dom, so OntOS's Shell unit tests still have to run on real React instead of Redact.Special things to note
0.2.1is immutable, so the fixed sidecar is@bleedingdev/tanstack-redact@0.2.2: still upstream@tanstack/redact@0.2.1plus our reviewed patch. The stream marker staysv1, as app-tools documents for a regenerated reviewed patch.0.2.2is on npm, app-tools keeps the signed0.2.1through an explicitpreviousForkedge, which never accepts upstream Redact. CI candidates and packed test cohorts install the rebuilt0.2.2for that edge, so every consumer suite tests the bytes that will ship. Release staging is never rewritten, so a cohort stays blocked until app-tools declares0.2.2.mode=sidecars sidecar_profile=tanstack-redact, then a PR that switches app-tools to0.2.2and deletes the edge, then the cohort.Change outline
sidecars.json / sidecar-profiles / packed-redact-probe tanstack-redact 0.2.1 -> 0.2.2 verify-sidecars unpublishedForkEdges + { app-tools, '@tanstack/redact', previousFork: '0.2.1' } // exact fork alias only app-tools declares npm:@bleedingdev/tanstack-redact@0.2.1 monorepo install -> signed 0.2.1 from npm CI candidate (--tag ci) -> rewritten to 0.2.2, served from the candidate registry packed test cohort edges -> 0.2.1 spec, 0.2.2 tarball release staging -> unchanged -> "pins 0.2.1 but sidecar stages 0.2.2" (blocked)🤖 Generated with Claude Code