Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds FPGA2 instance resource requirements to legacy Dragen 4.2 workflows to ensure they run on appropriate hardware infrastructure.
Key Changes:
- Added ResourceRequirement specifications for FPGA2 instances with standardized resource allocations
- Applied changes across tumor-normal and transcriptome pipeline managers
- Configured all legacy Dragen 4.2 workflow steps to use f2 instance types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/workload/stateless/stacks/tumor-normal-pipeline-manager/lambdas/get_boolean_parameters_from_event_input_py/get_boolean_parameters_from_event_input.py | Added ResourceRequirement blocks for both germline and somatic Dragen steps specifying fpga2 instance type with 24 cores and 256GB RAM |
| lib/workload/stateless/stacks/transcriptome-pipeline-manager/lambdas/get_boolean_parameters_from_event_input_py/get_boolean_parameters_from_event_input.py | Added ResourceRequirement block for transcriptome Dragen step specifying fpga2 instance type with 24 cores and 256GB RAM |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexiswl
deleted the
bugfix/update-resource-requirement-overrides-for-legacy-workflows
branch
January 5, 2026 08:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in overrides for wts and tn workflows to support F2 instance types