isoInstaller: fix interactive (no-kickstart) ISO install - #45
Merged
oliverkurth merged 1 commit intoJun 5, 2026
Merged
Conversation
Booting the ISO interactively (no ks= boot param, no -c config, no VMware
guestinfo.kickstart.*) was broken by two coupled regressions:
1) _load_ks_config_platform()/_load_ks_config_vmware() returned None when
no platform kickstart exists; __init__ then crashed at
'if "live" not in install_config' with:
TypeError: argument of type 'NoneType' is not a container or iterable
Fix: return an empty {} config instead of None.
2) The 'live' block unconditionally stamped install_config['live']=True,
making the empty interactive config truthy. installer.configure() only
runs the UI configurator when 'not install_config', so the UI was
skipped and _check_install_config() raised 'No disk configured'.
Fix: only stamp 'live' on a non-empty (kickstart) config; leave the
interactive config empty so the UI runs (live then defaults via
_add_defaults()).
Regression introduced by 9fc8733 on top of 0a72c3a.
Co-Authored-By: Daniel Casota <dcasota@gmail.com>
Contributor
Author
|
Part of a coordinated Photon 5.0 installer fix set:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Booting a Photon ISO interactively (no
ks=boot parameter, no-cconfig, and no VMwareguestinfo.kickstart.*) is broken by two coupled regressions:_load_ks_config_platform()/_load_ks_config_vmware()returnNonewhen no platform-provided kickstart exists.IsoInstaller.__init__then dereferences it atif 'live' not in install_config, raising:TypeError: argument of type 'NoneType' is not a container or iterable.'live'block unconditionally setsinstall_config['live'] = True, making the otherwise-empty interactive config truthy.installer.configure()runs the curses UI configurator only whennot install_config, so the UI is skipped and_check_install_config()fails withNo disk configured.Fix
{}config instead ofNone.'live'flag is stamped only on a non-empty (kickstart) config, so the interactive config stays falsy and the UI configurator runs ('live'then defaults via_add_defaults()).Regression introduced by 9fc8733 on top of 0a72c3a. Verified end-to-end with an interactive install on a VMware VM.
🤖 Generated with Claude Code