yarascan: warn when options will not affect the rules that get used - #2020
Open
ChrisJr404 wants to merge 1 commit into
Open
yarascan: warn when options will not affect the rules that get used#2020ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This picks up #1056.
process_yara_optionsreads a handful of options straight out of the config dict, and it was easy for the options a user set and the rules object it builds to drift apart without any feedback.Two cases in particular were silent:
insensitiveandwideonly ever get applied toyara_stringrules. If you pass them alongside--yara-fileor--yara-compiled-filethey do nothing, but nothing tells you that.So I beefed up the option checking a little (the lighter of the two options @ikelos floated on the issue): it now logs a warning in both of those cases and names which options or sources are being ignored. Behaviour is otherwise unchanged, no signature change and no version bump needed.
Added a small unit test covering the rule sources and the new warnings.