Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some strings in the Romanian locale (
ro.ts) were still in English, and a few others did not match what the English string says. This PR translates the missing ones and fixes the rest.opendismisscalendar.todaytimePicker.minutetimePicker.secondrules.excludehotkey.shortcutNotes:
openuses the same form as the existingclose: '脦nchide葲i', since the two are the open/close labels of the menu toggle.dismissis the default button text ofVSnackbarQueue. "脦nchide葲i" is the usual Romanian label for dismissing a notification.calendar.todaymatches the existingdatePicker.ariaLabel.currentDate: 'Ast膬zi, {0}'.timePicker.minuteandtimePicker.secondare field labels. "Minute" and "Secunde" are plural in Romanian, so they now use the singular, likehour: 'Or膬'and like English.rules.excludealways receives a single character (seecomposables/rules/rules.ts), so the message is now singular.hotkey.shortcutwas missing the preposition. "Comand膬 rapid膬 de la tastatur膬" is the standard Romanian term.Left as is on purpose:
confirmEdit.ok,timePicker.am,timePicker.pmand the key names inhotkey(Ctrl, Command, Shift, Alt, Option, Enter, Escape, Backspace, plus) are the same as in English, which is what Romanian keyboards and UIs use.Checked that
ro.tsstill has the same 137 keys asen.ts, that every{0}and{1}placeholder is kept, and thattsc --noEmitpasses on the file.Markup:
Open the playground with
?locale=ro(for examplehttp://localhost:8090/?locale=ro).