WPB-28093: add dedicated Meeting errors description - #5455
Merged
Conversation
blackheaven
force-pushed
the
gdifolco/WPB-28083-meetings-errors
branch
from
August 17, 2026 16:42
5ad4a79 to
8725784
Compare
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-28083-meetings-errors
branch
from
August 17, 2026 17:02
104a466 to
697976c
Compare
blackheaven
changed the title
fisx
approved these changes
Aug 19, 2026
| -- @CanThrow 'MeetingError'@. Every constructor keeps the @invalid-op@ label | ||
| -- but carries an explicit message; 'InvalidTimes' additionally records which | ||
| -- validation failed. | ||
| data MeetingError |
Contributor
There was a problem hiding this comment.
(Off topic for this PR, but why do we categorize errors by "micro"-services rather than subsystems?)
| type instance MapError 'CodeStoreNotFound = 'StaticError 404 "code-store-not-found" "Code store not found" | ||
|
|
||
| -- | Errors raised by the meetings subsystem, exposed at the API level via | ||
| -- @CanThrow 'MeetingError'@. Every constructor keeps the @invalid-op@ label |
Contributor
There was a problem hiding this comment.
Why not different labels? Clients need the label to understand the error and render / translate it for the user. "message" is human-readable and should be ignored by client logic.
On the other hand, maybe you don't want to mess with the API for compatibility reasons. Your call.
Contributor
Author
There was a problem hiding this comment.
It's mostly for compatibility reasons.
Currently clients don't interpret failures, but a generic description make debuggi_ng so much harder.
blackheaven
force-pushed
the
gdifolco/WPB-28080-meetings-update-24h
branch
from
August 19, 2026 10:53
fcf675a to
6335643
Compare
Base automatically changed from
gdifolco/WPB-28080-meetings-update-24h
to
develop
August 19, 2026 13:43
blackheaven
force-pushed
the
gdifolco/WPB-28083-meetings-errors
branch
from
August 19, 2026 14:20
e4a8c69 to
1647724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-28093
Checklist
changelog.d