Encapsulate util.cpp's own runtime state as static, not global - #5783
Merged
Conversation
2 WLED_GLOBAL variables were referenced only in util.cpp: jsonBufferLock, jsonBufferLockMutex. Converted both to file-local `static`, preserving the #if defined(ARDUINO_ARCH_ESP32) guard around jsonBufferLockMutex. No behavior change - purely a storage-class change. Verified: esp32dev builds and links cleanly via `pio run -e esp32dev` (1,320,319 bytes flash, no warnings from either changed file). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe change moves JSON buffer synchronization state into file-private storage in ChangesJSON buffer state encapsulation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
DedeHai
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of an ongoing pass identifying
WLED_GLOBALdeclarations that are actually only referenced in one file (see #5777-#5782 for earlier ones). 2 more turned out to be private toutil.cpp:jsonBufferLock,jsonBufferLockMutex.Converted both to file-local
static, preserving the#if defined(ARDUINO_ARCH_ESP32)guard aroundjsonBufferLockMutex(it's a FreeRTOS semaphore, ESP32-only).No behavior change — purely a storage-class change.
Test plan
esp32dev: builds and links cleanly viapio run -e esp32dev— 1,320,319 bytes flash, no warnings.wled00/,usermods/) that neither converted variable is referenced outsideutil.cpp.🤖 Generated with Claude Code
Summary by CodeRabbit