Repository navigation
Updates to scanner, PHP parser and lexer - #384
Merged
Merged
Conversation
jsturgill
approved these changes
Aug 27, 2026
| def _is_within_root(self, path: bytes) -> bool: | ||
| """Return whether a resolved path is contained by the scan root.""" | ||
| try: | ||
| return os.path.commonpath((self.root_path, path)) == self.root_path |
Contributor
There was a problem hiding this comment.
note (non-blocking): root_path remains None until locate() initializes it. Today, search_directory() is only called by locate(), so the code is safe. A direct caller in the future that passes in a directory that contains a symlink could raise TypeError. Codex suggests making the method private or setting the value in __init__.
No change needed, but if you revisit the code from QA feedback, something to consider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.