fix: clarify repeated SHA-256 demo workload - #8
Merged
Conversation
dcbuild3r
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser demo described its workload as "17 rounds," which could read like one SHA-256 invocation or 17 of SHA-256's internal rounds. The circuit selector, public statement, and runtime status now state that the circuit chains 17 full SHA-256 hashes over a 32-byte preimage.
The result panel also shows an
Avg. time / hashKPI, calculated as the measured proof-generation time divided by the circuit's 17 full hashes. Its tooltip makes that calculation explicit.Validation:
bun run format:checkbun run checkbun run build