Zook: return the final evaluation point from prove - #274
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
shreyas-londhe
force-pushed
the
ys/zook-prover-final-eval-point
branch
from
August 26, 2026 10:42
bc2aa3f to
78e9460
Compare
BornPsych
marked this pull request as ready for review
August 27, 2026 09:40
zkfriendly
requested changes
Aug 31, 2026
zkfriendly
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! thanks. Only thing is CI is failing due to a Clippy error; it's coming from an unchanged file, but it would be nice to fix it here and then merge with a green CI.
zkfriendly
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #270 — review that first; this PR's diff is only the last commit.
What
ProtocolConfig::provecurrently returns()and discards everything the transcript derived, so a caller that wants to continue reasoning about the proof (e.g. wiring Zook into an outer protocol, or checking prover/verifier agreement in tests) has no way to get at the final evaluation point. This PR returns it.provenow returns aProverClaim<F>:These are the prover-side mirror of the
FinalClaimfields the verifier already returns.How
ProverRoundStategainsall_round_challenges: Vec<M::Target>, accumulating each round's sumcheck challenges in transcript order.evaluation_pointsare appended, giving the full point in the same order the verifier reconstructs it.debug_assertpinsevaluation_point.len() == log2(vector_size).let _ =; it is now used.Tests
build_and_provereturns aProvenstruct instead of a 4-tuple — the tuple was already 4 fields wide and this adds a 5th.evaluation_pointandrlc_coefficientsmatch the verifier'sFinalClaim, so a divergence between the two sides fails loudly rather than silently.cargo test zook→ 21 passed.cargo fmt --checkandcargo clippy --all-targetsclean.