Keep SnakeMotionController.reset start cell and no-arg form - #8
Open
kvnloo wants to merge 1 commit into
Open
Conversation
reset({ startCell }) never stored that cell, so a later reset() rebuilt
from the constructor origin. Also default the options bag so reset()
does not throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reset({ startCell })never stored that cell on the controller, so a laterreset()rebuilt from the constructor origin.reset()with no object also threw on destructuring.Persist startCell / direction / length, and default the options bag.
Pin:
node --experimental-default-type=module --test gameblocks/modules/actor-motion/SnakeMotionController.test.jsSHA:
e8c9cea6dc8b9175f5e9e2de11979b91240bdaa8No origin issue. Origin target: xt4d/GameBlocks (do not open until Linear HITL is Done).