Repository navigation
Conversation
eb6c8c5 to
cbde1ab
Compare
|
@greptile review |
 Tested 4 flows, found no issues. What we tested
Took 2 attempts. TREX adjusted its test setup between them. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
cbde1ab to
1ddde65
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35b5c135bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cf10642cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-page sticky and overflow behavior still needs Chromium and Safari validation beyond the added PDisk scenario.
1 open issue
What changed in this PR
Keeps refresh controls visible while scrolling entity pages, addressing #3436.
Changes:
- Adds a shared sticky refresh control across five entity pages.
- Makes tabs and section headings sticky and removes disk/group Back buttons.
- Extends PDisk scrolling, refresh, and browser-navigation coverage.
| File | Description |
|---|---|
| tests/suites/storage/vdiskPage.test.ts | Tests sticky controls and browser navigation. |
| src/containers/VDiskPage/VDiskPage.tsx | Uses sticky refresh; removes Back button. |
| src/containers/VDiskPage/VDiskPage.scss | Adds sticky tabs and control spacing. |
| src/containers/VDiskPage/i18n/en.json | Removes unused Back label. |
| src/containers/Tablet/Tablet.tsx | Integrates sticky refresh and layout wrappers. |
| src/containers/Tablet/Tablet.scss | Adjusts scrolling, tabs, and spacing. |
| src/containers/StorageGroupPage/StorageGroupPage.tsx | Uses sticky refresh; removes Back button. |
| src/containers/StorageGroupPage/StorageGroupPage.scss | Makes storage heading sticky. |
| src/containers/StorageGroupPage/i18n/en.json | Removes unused Back label. |
| src/containers/PDiskPage/PDiskPage.tsx | Uses sticky refresh; removes Back button. |
| src/containers/PDiskPage/PDiskPage.scss | Adds sticky tabs and control spacing. |
| src/containers/PDiskPage/i18n/en.json | Removes unused Back label. |
| src/containers/Node/Node.tsx | Separates sticky refresh from metadata. |
| src/containers/Node/Node.scss | Adjusts sticky tabs and configuration height. |
| src/components/AutoRefreshControl/StickyAutoRefreshControl.tsx | Adds shared refresh wrapper. |
| src/components/AutoRefreshControl/StickyAutoRefreshControl.scss | Defines floating sticky positioning. |
Review effort: Balanced
Stand
Resolves #3436
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 65.20 MB | Main: 65.20 MB
Diff: 2.49 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information
The changes since the previous review appear safe to merge.Summary
Keeps refresh controls visible across five entity pages with a shared
StickyAutoRefreshControl.git diff --checkpassed. Browser and backend tests were not run. Screenshot inspection was blocked because this session cannot read images. The linked issue could not be read because GitHub CLI was not authenticated.Reviews (7) · Last reviewed commit: "fix: remove back buttons from disk and g..." · Reviewed by Greptile