Close the modal when its form has succeeded - #1
Merged
zelfroster merged 1 commit intoSep 19, 2026
Merged
zelfroster merged 1 commit into
zelfroster merged 1 commit into
Conversation
On master every create/post/add form ended its success path with popupMessage([h3 'Success' ...]), and popupMessage re-mounts #modal-container, so the form was replaced by the notice and the modal was effectively closed. The design-system branch swaps those notices for toast.success(), which does not touch the modal: the form stays open with its fields filled and its button live, and a second click creates the channel / forum / board / post / thread / identity again, re-adds the shared directory or the file, or re-sends the friend certificate. Every success branch now calls widget.closePopupMessage() before the toast. Failure branches keep the form open so the user can correct and retry, as before. The forum reply toast also says "Reply" rather than "Thread" when it was a reply. Sites: channel create/post, forum create/thread/reply, board create/post, add-friend Finish (both certificate kinds), identity create (signed and pseudonymous), identity edit (signed and pseudonymous), add shared directory, add file by link. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 1 of my review on RetroShare#129.
On master every create/post/add form ended its success path with
popupMessage([h3 'Success' …]), andpopupMessagere-mounts#modal-container, so the form was replaced by the notice: the modal was effectively closed. This branch swaps those fortoast.success(), which does not touch the modal, so the form stays open with its fields filled and its button live, and a second click creates the thing again (or re-sends the friend certificate).Every success branch now calls
widget.closePopupMessage()before the toast; failure branches keep the form open so the user can correct and retry. Sites: channel create/post, forum create/thread/reply, board create/post, add-friend Finish (both certificate kinds), identity create (signed and pseudonymous), identity edit (signed and pseudonymous), add shared directory, add file by link. The forum reply toast also says "Reply" rather than "Thread".Checked: eslint clean,
build.js --checkpasses. Not exercised in a browser here.Prepared with AI assistance (Claude), driven and reviewed by me.
🤖 Generated with Claude Code