Restore what the #121 follow-ups had fixed - #2
Merged
zelfroster merged 2 commits intoSep 19, 2026
Merged
zelfroster merged 2 commits into
zelfroster merged 2 commits into
Conversation
Seven regressions against master, each with the master behaviour as
the reference:
- The All section is back for channels, boards and forums, fed by the
full list sorted by popularity (all_*.js). Popular and Other are the
two halves of the NON-subscribed list, so the section labelled "All
Channels" hid every subscribed channel and the five most popular
ones; Other is labelled Other again. /channels/All, /boards/All and
/forums/All -- the phone default tab on master, so in bookmarks --
resolve again instead of rendering m(undefined). Forums have no
popularity split, so their empty "Other" page is gone.
- [hidden] { display: none !important } in the base sheet. The UA
sheet hides the attribute, but an author display rule on the same
element wins regardless of specificity, and the channel post
placeholder sets display: flex on itself: the "No image" box showed
under every real thumbnail. The image error fallback now clears the
attribute instead of writing an inline display.
- Distant chat: removing an attached picture clears the session's
copy too, or selectChatContact restores it and it goes out with the
next message after a contact switch.
- Ctrl/Cmd+Enter inserts a newline again in the shared composer
(execCommand first, keeps the undo stack, splice fallback), and the
field carries enterkeyhint=send again for phone keyboards.
- The in-channel post search is rendered at every width: the page
head, which hosts the channels search, is not rendered inside a
channel, so there was no post search on a desktop.
- The forum thread search shows on phones again: the <= 700px block
lost its display: flex.
- The channel and forum list filters live in module state, like the
isSearched flags they set: the field is unmounted inside a group and
recreated on the way back, and came back empty while every
non-matching group stayed hidden. Clearing the field resets the
flags instead of calling the per-forum loader with no id (which
POSTed getForumsInfo with forumIds [null]); a group reloaded while a
filter is active is filtered too. The channels and posts fields gain
a clear button.
- Modal close buttons get the 44px touch box under the touch mixin;
the 26px pointer target is what master's phone padding rule used to
correct.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items 4–10 of my review on RetroShare#129: the things the RetroShare#121 follow-ups had fixed, each restored with master as the reference.
all_*.js), fed by the full list sorted by popularity. Popular and Other are the two halves of the non-subscribed list, so the section labelled "All Channels" hid every subscribed channel and the five most popular; Other is labelled Other again./channels/All,/boards/All,/forums/All(the phone default tab on master, so in bookmarks) resolve again instead of renderingm(undefined). Forums have no popularity split, so their empty "Other" page is gone.[hidden] { display: none !important }in the base sheet. The UA sheet hides the attribute, but an authordisplayrule on the same element wins regardless of specificity, and the channel post placeholder setsdisplay: flexon itself: the "No image" box showed under every real thumbnail (defnax's screenshot). The image error fallback now clears the attribute instead of writing an inline display.selectChatContactrestores it and it goes out with the next message after a contact switch.execCommandfirst, keeps the undo stack, splice fallback), and the field carriesenterkeyhint=sendagain.display: flex.isSearchedflags they set: the field is unmounted inside a group and recreated on the way back, and came back empty while every non-matching group stayed hidden. Clearing resets the flags instead of calling the per-forum loader with no id (which POSTedgetForumsInfowithforumIds: [null]); a group reloaded under an active filter is filtered too. The channels and posts fields gain a clear button.touchmixin; the 26px pointer target is what master's phone padding rule used to correct.Checked: sass reproduces
styles.css, eslint clean,build.js --checkpasses. Not exercised in a browser here.Prepared with AI assistance (Claude), driven and reviewed by me.
🤖 Generated with Claude Code