Repository navigation
fix(codex): keep dead and expired logins visible as status cards - #41
Merged
Merged
Conversation
A Codex pool login marked dead, or whose access token had expired, was skipped before fetching, so the account vanished from Resetwatch while the Hermes Accounts tooltip still listed it with "Sign in again". Those logins now produce a card with no numbers and a reason: sign in again for a dead login, or "expired, not checked" for an expired token, which Hermes may still renew. No vendor call and no token refresh. A healthy login for the same account, from the pool or the Codex CLI, still wins and hides the stale card. Part of #40, reported by @Majber. Carrying the vendor observation time through the probe cache is left for a follow-up.
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40, reported by @Majber.
A Codex pool login marked
dead, or whose access token had expired, was skipped before fetching. The account vanished from Resetwatch while the Hermes Accounts tooltip still listed it with "Sign in again".Those logins now produce a card with no numbers and a reason:
No vendor call is made for them and nothing is refreshed. A healthy login for the same account, whether from the pool or the Codex CLI, still wins and hides the stale card.
Tests: three new cases in
test_codex_accounts.py: a dead duplicate doesn't hide a valid login, unusable logins stay visible with a reason, and a working CLI login replaces the stale pool card. The catalog copy is regenerated, andbuild_catalog.py --checkpasses.Not in this PR: carrying the vendor observation time through the probe cache, and the rest of the plan in #40.