Repository navigation
check-proof-statements: flag asides in a theorem statement - #1368
Conversation
Halmos says 'Without loss of generality' and 'Moreover' do not belong in the statement of a theorem (psw#422 item 2). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp
|
Claude finished review — View run Review of PR #1368 at I could not check the Halmos quotation ("How to Write Mathematics", section 10). The project library at The change adds "without loss of generality", "moreover" and "furthermore" to Minor, non-blocking:
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "ac60a9fa65c64352bedf85140da1b369b0920d6c",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The REASONING_RE change in check-proof-statements.py adds three aside phrases and feeds the unchanged scan path; new parametrized tests match the lowercased group output.",
"holistic_assessment": "Docs, changelog fragment and docstring agree with the behavior; the check stays warn-only and diff-scoped, so regression risk is low. Tests could not be run here because pytest is not installed."
}Stopping Point: Not a clean stopping point / work remains queued: session not done; this is a review-only run, so the review is posted by the harness. The Halmos quotation is unchecked because the book library was unavailable and the Reviewed commit: ac60a9f |
2026-10-30 00:09 UTC |
|
Merged as 010d187 under gha's standing merge grant: all 144 checks on head ac60a9f passed or were skipped (read from the paged check-runs endpoint), the review on that head was Ready for merge, and the PR was mergeable. Two gates were not run. The v3 tag has not slid; psw's new prose rule depends on it. Generated by Claude Code |
Requested by Ezra · project thread
Extends
check-proof-statementsso a statement also flags "without loss of generality", "moreover" and "furthermore", the asides Halmos says "do not belong in the statement of a theorem" ("How to Write Mathematics", 1970, section 10; text read). This is the check half of item 2 of psw#422; psw#426 already covers the reasoning words.One regex alternation, same warn-only, diff-scoped engine, so no new action. Tests: three new cases (each aside flagged in a statement, an aside in the proof not flagged); suite 79 passed. Docs: reference page and a changelog fragment. No sweep.
Generated by Claude Code