Repository navigation
Split the indicator section into one div per subfile - #585
Closed
d-morrison wants to merge 1 commit into
Closed
d-morrison wants to merge 1 commit into
d-morrison wants to merge 1 commit into
Conversation
Pure move: each div is unchanged and the section file includes it in place, so the rendered main content is identical. No heading changes. check-one-div-per-subfile judges a whole touched file, so this lets the indicator headings be promoted in a later PR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9r2idFsJ4pHCsRGyGx
Contributor
|
Claude finished review — View run I fetched PR #585 live just now. It is open, not a draft and not merged, and its head is still I did not render the site or run CI; the review rests on reading the diff and checking the include paths and anchors. VerdictReady for merge This is a pure refactor. It moves six Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "4ad3b9ab829e8897a27aabb32fc08b1b2a6aac09",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Moved six definition and example divs into separate subfiles with verbatim content, matching include path conventions and preserving all div ids and cross-references.",
"holistic_assessment": "Pure refactor satisfying the one-div-per-subfile rule with no regression risk to anchors, scope creep, or build hygiene concerns."
}Stopping Point: Clean stopping point reached --- session done; UMS executed; no follow-up items pending Reviewed commit: 4ad3b9a |
Contributor
Contributor
2026-11-02 21:49 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure move: each div in
_subfiles/indicator-functions/_sec-indicator-functions.qmdgoes to its own subfile and the section file includes it in place. The div text is unchanged and the rendered main content is identical.rem-iverson-indicatorstays in the section file to keep this PR under the size cap.Why:
check-one-div-per-subfilejudges a whole touched file, so the indicator headings (promoted to level 1 in a follow-up stacked PR) cannot be changed while the file holds eight divs. This blocked #582.Part of the mds heading promotion, with #569, #570, #571, #582, #583 and #584.
Generated by Claude Code