Skip to content

Split four multi-div subfiles into one div per file (wave 1) - #244

Merged
d-morrison merged 1 commit into
mainfrom
split-multi-div-subfiles
Oct 23, 2026
Merged

d-morrison merged 1 commit into
mainfrom
split-multi-div-subfiles

Conversation

@d-morrison

@d-morrison d-morrison commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Wave 1 of the one-div-per-subfile rollout (gha#1176), owned by the Semantic macro enforcement thread.

The earlier version of this PR split all 61 multi-div subfiles at once.
Ezra asked for minimal batches instead, so this PR now holds four files:

  • _cor-best-predictor-argmin.qmd
  • _cor-best-predictor-unique.qmd
  • _def-binomial.qmd
  • _def-cond-expectation.qmd

Each top-level div moved to _subfiles/<stem>/_<name>.qmd, and the original file now includes them in order.
The include-expanded text of all 11 top-level pages is unchanged (checked by recursive expansion against main).
The remaining 57 files follow in later waves, each opened after the previous one merges.

The check-term-links check reads moved lines as new until gha#1187 merges and the v3 tag slides.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V6MvQvUgPePB2ndiLAgpHs

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

check / check-term-links fails on this PR, and the cause is not the content.
The split moves each div into its own file, so the check reads every moved first use as a new line.
Moving a line should not count as adding it.
The fix is gha#1187, which gives check-term-links the same moved-line exemption as the other diff-scoped checks (tracked in gha#1176).
It is reviewed clean, with its last checks still running.
Consumers pin gha by tag, so this PR only sees the fix after gha#1187 merges and the v3 tag slides.
I will re-run the check once then, with a fresh run rather than a failed-jobs re-run.
Every other check is green or still running on this head, and the lint failures from the earlier head are fixed by 4870b45.


Generated by Claude Code

@d-morrison
d-morrison force-pushed the split-multi-div-subfiles branch from 4870b45 to 78e160d Compare October 23, 2026 08:37
@d-morrison d-morrison changed the title Split multi-div subfiles into one div per file Split four multi-div subfiles into one div per file (wave 1) Oct 23, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

A proof stays with its claim (Ezra, 2026-10-23). Include-expanded pages unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V6MvQvUgPePB2ndiLAgpHs
@d-morrison
d-morrison force-pushed the split-multi-div-subfiles branch from 78e160d to cacac5d Compare October 23, 2026 08:56
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Review of PR #244 at cacac5de8d0a1b2e660969e6883019076aba8e03

I found no new issues. This round is "wave 1" of the subfile split. The diff touches only _subfiles/: 26 added files and 4 modified files (_cor-best-predictor-argmin, _cor-best-predictor-unique, _def-binomial, _def-cond-expectation).

Checks I ran:

  • Include expansion: I expanded every {{< include >}} recursively on base 4f969d0 and on this head. For every top-level page, the text is identical once blank lines are dropped. The pages were index, notation, probability-basics, random-variables, independence, expectation, variance-covariance, distributions, limit-theorems, references and appendix-document-metadata.
  • Unresolved includes: The only one is latex-macros/macros.qmd. The submodule is empty in this checkout and my script reads files through git show, so it can't see it. The base side has the same gap.
  • New files: Every added file is referenced by an include, and each new include path resolves.
  • Anchors and paths: The #ids and page paths are unchanged, so links from course sites still hold.
  • Build hygiene: The diff has no _site/, _freeze/ or .quarto/ changes.
  • Math macros: The diff only moves existing math and adds none, so I did not run the macro check.
  • Not run: I did not render the site or run lintr, spell check, link check or the non-standard-character check. The preview render and CI still need to be green. The render is also where a duplicate-label warning from the split would show up.

This is a confirming review. The branch was rebased, so the prior round's commit 78e160d is no longer an ancestor of this head, and I re-checked the full diff against the base. The prior verdict was Ready for merge, from the 2026-10-23 review at 78e160d. That verdict still stands.

Verdict

Ready for merge, once the preview render and CI are green.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "cacac5de8d0a1b2e660969e6883019076aba8e03",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Recursively expanded all includes for every top-level page on base 4f969d0 and on the PR head; the expanded text is identical apart from the empty macros submodule, and every added _subfiles path is referenced and resolves.",
  "holistic_assessment": "The change is a scoped mechanical refactor that preserves page paths and anchors with no build artifacts; the remaining risk is only the Quarto render and CI checks, which were not run here."
}

Reviewed commit: cacac5d

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1921 (review) — run

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-23 09:40 UTC

@d-morrison
d-morrison merged commit 5f78d1c into main Oct 23, 2026
29 of 30 checks passed
@d-morrison
d-morrison deleted the split-multi-div-subfiles branch October 23, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants