Skip to content

refactor(automation-runtime): classify skip timeout via ledger reason - #1427

Merged
ScriptedAlchemy merged 1 commit into
codex/tracedecay-total-redesign-plan-reopenedfrom
cursor/skip-reason-ledger-13ea
Sep 16, 2026
Merged

ScriptedAlchemy merged 1 commit into
codex/tracedecay-total-redesign-plan-reopenedfrom
cursor/skip-reason-ledger-13ea

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

STOP-REFETCH rebase onto tip d2c9294089 (after #1415 Kiro advisory land). Single commit unchanged in intent.

Migrate skipped_terminal_failure_class from an inline "session_evidence_timed_out" string match to AutomationSkipReasonV1::from_ledger_reason, then keep only the typed SessionEvidenceTimedOut → Timeout mapping. Deletes the internal dual-path literal beside the canonical ledger parser.

Principle

migrate-callers-then-delete-legacy-apis — no shim left.

Test plan

  • commitlint from tip base
  • CI on tip base after rebase
  • Existing scheduler fixture still exercises the ledger sentinel string via the typed parser
Open in Web Open in Cursor 

@changeset-bot

changeset-bot Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 56c451a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review September 16, 2026 09:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T09:57:04.174902Z c1efdfe Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Route skipped_terminal_failure_class through AutomationSkipReasonV1
instead of an inline English string match. Delete the duplicate path.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/skip-reason-ledger-13ea branch from 74ccba2 to 56c451a Compare September 16, 2026 10:59
@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison codex/tracedecay-total-redesign-plan-reopened → cursor/skip-reason-ledger-13ea

Total Elapsed Time: 7.93s → 8.45s (+6.5%)
CPU Baseline: 90.42µs → 90.02µs (-0.4%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| Function                                 | Calls                      | Avg                              | P95                              | Total                            | % Total                      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| tracedecay-index-bench                   | 1 → 1 (+0.0%)              | 7.93s → 8.45s (+6.6%)            | 7.93s → 8.45s (+6.6%)            | 7.93s → 8.45s (+6.6%)            | 100.00% → 100.00% (+0.0%)    |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| domain.canonical.sha256                  | 85787 → 85787 (+0.0%)      | 33.25µs → 34.45µs (+3.6%)        | 103.17µs → 103.61µs (+0.4%)      | 2.85s → 2.96s (+3.9%)            | 35.97% → 34.99% (-2.7%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| code_index.workers.install               | 81 → 81 (+0.0%)            | 31.13ms → 36.36ms (+16.8%)       | 193.33ms → 226.89ms (+17.4%)     | 2.52s → 2.95s (+17.1%)           | 31.80% → 34.87% (+9.7%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| query.artifact.finalization.advance_wake | 28 → 28 (+0.0%)            | 53.41ms → 54.20ms (+1.5%)        | 424.67ms → 433.59ms (+2.1%)      | 1.50s → 1.52s (+1.3%)            | 18.86% → 17.97% (-4.7%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.sqlite              | 5 → 5 (+0.0%)              | 283.18ms → 285.08ms (+0.7%)      | 313.00ms → 313.26ms (+0.1%)      | 1.42s → 1.43s (+0.7%)            | 17.86% → 16.88% (-5.5%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| code_index.build.and_publish             | 2 → 2 (+0.0%)              | 709.74ms → 706.44ms (-0.5%)      | 989.86ms → 983.04ms (-0.7%)      | 1.42s → 1.41s (-0.7%)            | 17.90% → 16.73% (-6.5%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare    | 5 → 5 (+0.0%)              | 181.78ms → 236.59ms (+30.2%) ⚠️  | 201.59ms → 281.02ms (+39.4%) ⚠️  | 908.90ms → 1.18s (+29.8%) ⚠️     | 11.46% → 14.01% (+22.3%) ⚠️  |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings            | 5 → 5 (+0.0%)              | 221.08ms → 220.55ms (-0.2%)      | 248.77ms → 248.77ms (+0.0%)      | 1.11s → 1.10s (-0.9%)            | 13.94% → 13.06% (-6.3%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| domain.canonical.json_bytes              | 206681 → 206681 (+0.0%)    | 4.11µs → 5.29µs (+28.7%) ⚠️      | 4.32µs → 4.33µs (+0.2%)          | 849.85ms → 1.09s (+28.3%) ⚠️     | 10.72% → 12.93% (+20.6%) ⚠️  |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| code_index.extract.parser_artifact       | 276 → 276 (+0.0%)          | 3.82ms → 3.78ms (-1.0%)          | 6.21ms → 6.18ms (-0.5%)          | 1.05s → 1.04s (-1.0%)            | 13.30% → 12.36% (-7.1%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| code_index.restore.file_admit            | 260 → 260 (+0.0%)          | 2.77ms → 3.41ms (+23.1%) ⚠️      | 4.43ms → 5.84ms (+31.8%) ⚠️      | 719.98ms → 887.41ms (+23.3%) ⚠️  | 9.08% → 10.51% (+15.7%)      |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| code_index.build.materialize_full        | 1 → 1 (+0.0%)              | 703.36ms → 695.90ms (-1.1%)      | 703.59ms → 696.25ms (-1.0%)      | 703.36ms → 695.90ms (-1.1%)      | 8.87% → 8.24% (-7.1%)        |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| 🆕 code_index.lexical_source.batch_stage | 0 → 6 (+100.0%) ⚠️         | 0.00ns → 113.56ms (+100.0%) ⚠️   | 0.00ns → 159.65ms (+100.0%) ⚠️   | 0.00ns → 681.35ms (+100.0%) ⚠️   | 0.00% → 8.07% (+100.0%) ⚠️   |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| code_index.collect.materialize_full      | 1 → 1 (+0.0%)              | 686.74ms → 680.09ms (-1.0%)      | 686.82ms → 680.53ms (-0.9%)      | 686.74ms → 680.09ms (-1.0%)      | 8.66% → 8.05% (-7.0%)        |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows | 5 → 5 (+0.0%)              | 124.82ms → 125.08ms (+0.2%)      | 141.56ms → 140.77ms (-0.6%)      | 624.11ms → 625.39ms (+0.2%)      | 7.87% → 7.40% (-6.0%)        |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| 🗑️ code_index.build.assemble             | 2 → 0 (-100.0%) 🚀         | 291.61ms → 0.00ns (-100.0%) 🚀   | 299.89ms → 0.00ns (-100.0%) 🚀   | 583.22ms → 0.00ns (-100.0%) 🚀   | 7.35% → 0.00% (-100.0%) 🚀   |
+------------------------------------------+----------------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+

Generated with hotpath-rs

@ScriptedAlchemy
ScriptedAlchemy merged commit df0c327 into codex/tracedecay-total-redesign-plan-reopened Sep 16, 2026
9 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants