refactor: move consumer policies out of history and IDE helpers - #18
Merged
codeforester merged 1 commit intoJul 31, 2026
Merged
Conversation
This was referenced Jul 31, 2026
codeforester
marked this pull request as ready for review
July 31, 2026 04:10
codeforester
deleted the
enhancement/9-20260730-isolate-ide-history-policy
branch
July 31, 2026 04:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #9 by removing Base-specific IDE definitions and history command aliases from the generic package.\n\n- keeps only generic IDE parsing helpers in base_cli.ide_schema\n- lets consumers validate supported IDE names through read_user_config(..., supported_ides=...)\n- adds injectable history_display_command policy to CliProfile and Context\n- makes generic history formatting only normalize underscores to hyphens\n- adds boundary tests and documents the consumer policy\n\nThe coordinated Base consumer changes are in basefoundry/base#1821. Package renaming remains out of scope.\n\nValidation: uv run --extra dev pytest — 158 passed, 4 subtests passed.: