Repository navigation
Conversation
This gives cross platform consistency instead of relying on shell / bat scripts that might differ depending on the tools you call.
keith
force-pushed
the
ks/add-native-exclude-to-buildifier
branch
from
August 11, 2026 17:46
2f733ff to
87b261f
Compare
keith
marked this pull request as ready for review
August 18, 2026 21:23
Member
|
This is really useful, but the exclude syntax is pretty bespoke. Could we just match Bazel's What do you think of also interpreting excludes relative to the workspace root, not the current working directory? This is especially relevant if they are added to Smaller notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives cross platform consistency instead of relying on shell / bat
scripts that might differ depending on the tools you call.