Conversation
MegaIng
requested changes
Sep 20, 2026
MegaIng
left a comment
Contributor
There was a problem hiding this comment.
The parameters in body_behavior.yaml should be moved into a block "formation" or "positioning" so that it's clear that they belong together. This then also means "formation_include_supporter".
Also, the list of sliders and the way those values are being read out and put into the params in the debug script should be refactored to be maintainable. It's a large unmaintainable script but by tackling sections as we have to touch them we will get there ;-)
…gui sliders and rename gui internal variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #1056 but doesnt include all the there suggested features. Would be nice to merge it soon anyway to enable working on the positioning capsule without merge conflicts in the future
Checklist
pixi run build