fix(ui): continue to the identity provider after a challenge - #9620
Open
zourzouvillys wants to merge 1 commit into
Open
fix(ui): continue to the identity provider after a challenge#9620zourzouvillys wants to merge 1 commit into
zourzouvillys wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 9252160 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
9 tasks
zourzouvillys
force-pushed
the
theo/resume-enterprise-sso-after-challenge
branch
from
August 31, 2026 23:05
fc71f5d to
ba6c5ed
Compare
zourzouvillys
marked this pull request as ready for review
August 31, 2026 23:06
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Contributor
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
A sign-in whose only first factor is an enterprise connection has no factor to render, so resuming it into the factor-one card left the user on alternative methods with no way to reach their provider. The rule for when a sign-in hands off to a connection now lives in one place, and the resume follows it as the start page already did. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
zourzouvillys
force-pushed
the
theo/resume-enterprise-sso-after-challenge
branch
from
September 1, 2026 01:04
ba6c5ed to
9252160
Compare
Ephem
reviewed
Sep 2, 2026
Comment on lines
+48
to
+52
| function shouldHandOffToEnterpriseConnection(signIn: SignInResource): boolean { | ||
| return ( | ||
| hasOnlyEnterpriseSSOFirstFactors(signIn) && !hasMultipleEnterpriseConnections(signIn.supportedFirstFactors ?? null) | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
What's the intended behavior here? If the user has multiple factors, picks one enterprise SSO one, gets challenged and end up here to determine whether to continue, shouldn't we continue that specific factor which they had already chosen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #9619 — review the delta only; that one merges first.
A sign-in whose only supported first factor is an enterprise connection has no first factor to render. The start page knows this and hands off to the identity provider instead of routing to the factor-one card.
Resuming a sign-in after a verification challenge did not know it, and routed to factor-one regardless. With nothing there to render, the card falls through to "Use another method", which lists social providers only — so the user is stranded with no way to reach their provider and no way back. It affects every entry point that resumes through this path, including an organization invitation ticket.
The rule for when a sign-in hands off to a connection now lives in one place, and the resume follows it as the start page already did.
Effects and risks
shared.tsinto a module neither file imports, so the resume can use them without a cycle.hasMultipleEnterpriseConnectionsis re-exported from its old path, so existing importers are untouched.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change