Skip to content

fix(shared): classify local production keys as live - #9633

Open
brkalow wants to merge 1 commit into
mainfrom
brk/fix-local-prod-publishable-key
Open

fix(shared): classify local production keys as live#9633
brkalow wants to merge 1 commit into
mainfrom
brk/fix-local-prod-publishable-key

Conversation

@brkalow

@brkalow brkalow commented Sep 1, 2026

Copy link
Copy Markdown
Member

Description

Local production Frontend API hosts under .prod.lclclerk.com currently get a pk_test_ key because publishable-key generation treats every .lclclerk.com host as development. This makes ClerkJS load a production system instance as development and require a dev browser. This change excludes local production hosts from the legacy development rule while keeping existing development host behavior.

Run pnpm --filter @clerk/shared test -- src/__tests__/keys.spec.ts to verify the production and development host cases.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 1, 2026 5:46pm UTC
swingset Ready Ready Preview Sep 1, 2026 5:46pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b2874b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@clerk/shared Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/electron Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/headless Patch
@clerk/hono Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch
@clerk/swingset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9633

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9633

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9633

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9633

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9633

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9633

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9633

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9633

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9633

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9633

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9633

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9633

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9633

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9633

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9633

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9633

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9633

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9633

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9633

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9633

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9633

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9633

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9633

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9633

commit: b2874b7

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-01T17:51:25.340Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 1
🔴 Breaking changes 0
🟡 Non-breaking changes 2
🟢 Additions 0

🤖 This report was reviewed by claude-sonnet-4-6.


@clerk/fastify

Current version: 3.1.74
Recommended bump: MINOR → 3.2.0

Subpath .

🟡 Non-breaking Changes (1)

Modified: ClerkFastifyOptions
  type ClerkFastifyOptions = ClerkOptions & {
    hookName?: (typeof ALLOWED_HOOKS)[number];
    frontendApiProxy?: FrontendApiProxyOptions;
-   __internal_enableHandshake?: boolean;
  };

Static analyzer: Breaking change in type alias ClerkFastifyOptions: Type changed: import("@clerk/backend").ClerkOptions&{hookName?:(typeof import("@clerk/fastify").~ALLOWED_HOOKS)[number];frontendApiPr…import("@clerk/backend").ClerkOptions&{hookName?:(typeof import("@clerk/fastify").~ALLOWED_HOOKS)[number];frontendApiPr…

🤖 AI review (reclassified as non-breaking) (95%): The only change is the removal of the optional property __internal_enableHandshake? (indicated by the __internal_ prefix as an internal/private field); since it was optional, no well-typed consumer was required to provide it, and removing an optional input property does not break existing callers who simply omit it.

Subpath ./types

🟡 Non-breaking Changes (1)

Modified: ClerkFastifyOptions
  type ClerkFastifyOptions = ClerkOptions & {
    hookName?: (typeof ALLOWED_HOOKS)[number];
    frontendApiProxy?: FrontendApiProxyOptions;
-   __internal_enableHandshake?: boolean;
  };

Static analyzer: Breaking change in type alias ClerkFastifyOptions: Type changed: import("@clerk/backend").ClerkOptions&{hookName?:(typeof import("@clerk/fastify").~ALLOWED_HOOKS)[number];frontendApiPr…import("@clerk/backend").ClerkOptions&{hookName?:(typeof import("@clerk/fastify").~ALLOWED_HOOKS)[number];frontendApiPr…

🤖 AI review (reclassified as non-breaking) (95%): The removed property __internal_enableHandshake was optional and its name signals it was an internal/private field; removing an optional property from an input type (ClerkFastifyOptions is used as a plugin parameter) means no well-typed consumer code could be broken, since callers never needed to supply it and TypeScript won't error on the absence of an optional field.


Report generated by Break Check

Last ran on b2874b7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants