Skip to content

fix(shared): classify local production keys as live #9633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brkalow wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

fix(shared): classify local production keys as live #9633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-plants-smile.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Fix publishable-key generation for production instances in local Clerk environments.
2 changes: 2 additions & 0 deletions packages/shared/src/__tests__/keys.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ describe('buildPublishableKey(frontendApi)', () => {
['foo-bar-13.clerk.accounts.dev', 'pk_test_Zm9vLWJhci0xMy5jbGVyay5hY2NvdW50cy5kZXYk'],
['clerk.boring.sawfly-91.lcl.dev', 'pk_test_Y2xlcmsuYm9yaW5nLnNhd2ZseS05MS5sY2wuZGV2JA'],
['clerk.boring.sawfly-91.lclclerk.com', 'pk_test_Y2xlcmsuYm9yaW5nLnNhd2ZseS05MS5sY2xjbGVyay5jb20k'],
['clerk.prod.lclclerk.com', 'pk_live_Y2xlcmsucHJvZC5sY2xjbGVyay5jb20k'],
['clerk.example.prod.lclclerk.com', 'pk_live_Y2xlcmsuZXhhbXBsZS5wcm9kLmxjbGNsZXJrLmNvbSQ'],
];

test.each(cases)(
Expand Down
8 changes: 5 additions & 3 deletions packages/shared/src/keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,11 @@ const PUBLISHABLE_FRONTEND_API_DEV_REGEX = /^(([a-z]+)-){2}([0-9]{1,2})\.clerk\.
* @returns An unpadded base64-encoded publishable key with appropriate prefix (pk_live_ or pk_test_).
*/
export function buildPublishableKey(frontendApi: string): string {
const isDevKey =
PUBLISHABLE_FRONTEND_API_DEV_REGEX.test(frontendApi) ||
(frontendApi.startsWith('clerk.') && LEGACY_DEV_INSTANCE_SUFFIXES.some(s => frontendApi.endsWith(s)));
const isLegacyDevKey =
frontendApi.startsWith('clerk.') &&
LEGACY_DEV_INSTANCE_SUFFIXES.some(s => frontendApi.endsWith(s)) &&
!frontendApi.endsWith('.prod.lclclerk.com');
const isDevKey = PUBLISHABLE_FRONTEND_API_DEV_REGEX.test(frontendApi) || isLegacyDevKey;
const keyPrefix = isDevKey ? PUBLISHABLE_KEY_TEST_PREFIX : PUBLISHABLE_KEY_LIVE_PREFIX;
return `${keyPrefix}${isomorphicBtoa(`${frontendApi}$`).replace(/=+$/, '')}`;
}
Expand Down
Loading