feat(manipulation): add heuristic grasp provider - #3709
Conversation
❌ 2 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Greptile SummaryThis change adds a deterministic, PCA-based heuristic grasp provider, focused proposal tests, and generated catalog registration. The rectangular-fixture test checks that the gripper approaches from above but does not check its yaw, so a rotation that places the jaws across the fixture's wide dimension can remain undetected. T-Rex validation blockedThe focused test could not start because the Python package Confidence Score: 4/5The provider's yaw behavior should receive explicit regression coverage before it is relied on for rectangular-object grasp planning. The remaining finding is limited to test coverage: the current assertion constrains the downward approach direction but not the yaw-dependent jaw direction. Files Needing Attention: dimos/manipulation/grasping/test_heuristic_grasp.py needs a jaw-axis assertion for the non-square rectangular fixture.
What T-Rex did
Reviews (1): Last reviewed commit: "feat(manipulation): add heuristic grasp ..." | Re-trigger Greptile |
a1bf6c4 to
4a436c0
Compare
Contribution path
Problem
Pick-and-place needs a lightweight grasp provider that does not require the optional GraspGenX runtime.
Solution
HeuristicGraspModule, implementing the existingGraspGenSpec.How to Test
AI assistance
OpenCode with gpt-5.6-terra assisted with implementation and validation. The author will review the public method descriptions before they are added.
Checklist