Repository navigation
types: reject light client attack evidence without a signed header - #65
Merged
Merged
Conversation
Kefancao
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #59 onto the current
dydx-fork-v0.38.5tip, unchanged.LightClientAttackEvidence.ValidateBasiccheckedConflictingBlockfor nil but then readConflictingBlock.Header, a field promoted through the embedded*SignedHeader, so evidence whoseconflicting_block.signed_headeris omitted dereferenced nil. The same check was added upstream in cometbft#5757. Evidence received over the evidence channel is recovered by MConnection, but the block validation path is not, so this applies to proposed blocks as well as gossip.