Repository navigation
feat: expose MSVC header and library subsets as source directories - #21
Open
TrapsterDK wants to merge 1 commit into
Open
TrapsterDK wants to merge 1 commit into
TrapsterDK wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20.
@msvc_runtimecopies the vcruntime and COM support headers and the COM, common, dynamic CRT and static CRT libraries intosubsets/when the repository is fetched. They are exposed assubdirectorytargets:msvc_vcruntime_include,msvc_com_support_includeandmsvc_{com,common,dynamic,static}_libraries, the last four selecting x64 or arm64 by platform. A toolchain can then depend on them directly instead of copying them withcopy_to_directory.Test:
e2e/smokebuilds all six targets insmoke_test. I ran it on Linux and checked that the fetched repository holds the 50 expected files.Assisted by Claude.