Skip to content

Korean - #246

Open
helloworldxdwastaken wants to merge 1 commit into
iliyami:mainfrom
helloworldxdwastaken:localization/korean
Open

Korean#246
helloworldxdwastaken wants to merge 1 commit into
iliyami:mainfrom
helloworldxdwastaken:localization/korean

Conversation

@helloworldxdwastaken

Copy link
Copy Markdown

Part of #12. Machine-assisted; native review needed.

616 static strings. Version, build and localization checks pass; interpolated strings keep their English fallback.

Preview

@iliyami iliyami left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @helloworldxdwastaken, and thank you for being upfront that this is machine-assisted. I reviewed it carefully:

  • Code and safety: all good. Only the language plumbing changes (enum case, locale mapping, dictionary, kept .lproj folders, Info.plist), existing translations are untouched, and the new strings contain no URLs, invisible characters, em dashes, duplicate keys, or lost placeholders. The tests mirror the Italian ones and add the language to every per-module loop. Merged with current main, the full suite passes locally (1,056 tests, 0 failures). Nice touch translating the three strings no other language had yet ("Scanning disk…", "No items found", "System").
  • Translation: good base, needs a fix pass. I had every entry reviewed against the English meaning and Apple's own terminology. Most of it is accurate, but there are machine-translation errors, a few of which change what a safety message says. Those must be fixed before merge.

Korean: required fixes

Line numbers refer to Sources/MacCleanKit/Localization.swift in this PR. Most safety dialogs (Trash, restore, permanent delete, Docker prune) are correct and there's no leftover Chinese.

Critical

  • 375 "Storage critical" became "스토리지가 중요함" ("storage is important"), so the low-disk alert loses its warning → "저장 공간 부족" (or "저장 공간이 매우 부족함").

Major

  1. 419 "다음 발사를 재생성했습니다" (rocket launch) → "앱 임시 파일입니다. 다음 실행 시 다시 생성됩니다."; 262 "다음 출시 시" → "다음 실행 시".
  2. Casual / dictionary forms: 391 "이미 갔어" → "이미 없음"; 408 "청소했다" → "정리됨"; 441 "청소하다" → "정리 가능"; 413 → "정리 대상으로 선택됨".
  3. 240 "확장자" means file extension, "{browser}이" breaks after Firefox, and it reads as a statement → "{browser} 앱이 열려 있어 아무것도 삭제하지 않았습니다. 주소 표시줄에서 {url}을(를) 열어 {browser}에서 확장 프로그램을 제거하세요."
  4. 722 "확인되지 않은" means "unverified", not "unchecked" → "선택하지 않은 언어 파일은 시스템 불필요 파일에서 제거될 수 있습니다."
  5. 468 (Restore) reads as "restore everything cleanly" → "정리 작업 전체를 한 번의 클릭으로 되돌립니다. 이미 휴지통에서 비워졌거나 원래 위치에 새 파일이 있는 항목은 건너뜁니다."
  6. 505 "이 기능을 사용하는" weakens the safety reassurance → "이 Mac에서 이 파일을 사용하는 항목은 없습니다."
  7. 242 past tense in a warning shown before the task runs → "처음부터 다시 작성됩니다 … 정확하지 않습니다".
  8. 429 "응용" is cut off → "앱"; 378 "설치자" → "설치 프로그램"; 426 "앱 오픈" → "앱이 열려 있음".
  9. Apple terms: Full Disk Access "전체 디스크 접근 권한" (311, 379, 809, 810); "관리자 권한" (400, 701); keep "Launch Agent"/"Launch Daemon" consistent (347, 348, 594, 609).
  10. Consistency: scan is 검사 / 스캔 / 검색 (검색 means search), clean is 청소 / 정리, junk is 정크 / 불필요 파일, Smart Scan is 스마트 검사 / 스마트 스캔. Please pick one each (suggest 검사, 정리, 불필요한 파일, 스마트 검사).

Worth fixing (minor): one politeness style (-세요) throughout; "방문 기록" for Safari history (280, 650); "꺼짐" for Off (395); "확장 프로그램" not "확장"; "메뉴 막대"; "홈 폴더"; no space before colons (241, 275, 400).

Housekeeping (applies to all five of your PRs)

  1. All five PRs set VERSION to 1.25.5, and main is moving to 1.25.7 (#249, #250, #251). They'll be merged one at a time, so please rebase each onto main right before it's ready and bump to the next free patch version then (bash scripts/check-version-sync.sh).
  2. #250 replaces the Language Cleanup caption key in Settings (英文、基础资源、中文、俄文和德文会始终保留… becomes Base 资源、Mac Sai 的界面语言以及你的 Mac 在“语言与地区”中设置的语言会始终保留…), and #251 adds two launch-at-login error sentences with a {message} placeholder. After rebasing, please translate those and drop the old caption entry plus the 开启/关闭 entries, which are no longer used.
  3. Next time, please comment on #12 to claim a language before starting, so two people don't translate the same one. And since these are machine-assisted, a note on #12 inviting a native speaker to proofread would be very welcome.

Once the fixes above are in, I'm happy to merge. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants