Korean

Sources/MacCleanKit/CleanupStrings.swift

@@ -21,6 +21,7 @@ public enum CleanupStrings {
         case .es: return "\(selectedText) de \(totalText) \(total == 1 ? "elemento seleccionado" : "elementos seleccionados")"
         case .ptBR: return "\(selectedText) de \(totalText) \(total == 1 ? "item" : "itens") \(selected == 1 ? "selecionado" : "selecionados")"
         case .ja: return "\(selectedText) / \(totalText) 項目を選択済み"
+        case .ko: return "\(totalText)개 항목 중 \(selectedText)개 선택됨"
         case .ru:
             return "Выбрано \(selectedText) из \(totalText) \(L10n.russianPlural(total, one: "объекта", few: "объектов", many: "объектов"))"
         case .zhHans: return "已选择 \(selectedText) / \(totalText) 项"
@@ -38,6 +39,7 @@ public enum CleanupStrings {
         case .es: return "¿Limpiar \(number) \(count == 1 ? "elemento" : "elementos")?"
         case .ptBR: return "Limpar \(number) \(count == 1 ? "item" : "itens")?"
         case .ja: return "\(number) 項目をクリーンアップしますか？"
+        case .ko: return "\(number)개 항목을 정리할까요?"
         case .ru:
             return "Очистить \(number) \(L10n.russianPlural(count, one: "объект", few: "объекта", many: "объектов"))?"
         case .zhHans: return "清理 \(number) 项？"
@@ -55,6 +57,7 @@ public enum CleanupStrings {
         case .es: return "\(number) \(count == 1 ? "elemento" : "elementos")"
         case .ptBR: return "\(number) \(count == 1 ? "item" : "itens")"
         case .ja: return "\(number) 項目"
+        case .ko: return "\(number)개 항목"
         case .ru:
             return "\(number) \(L10n.russianPlural(count, one: "объект", few: "объекта", many: "объектов"))"
         case .zhHans: return "\(number) 项"

Sources/MacCleanKit/Constants.swift

@@ -202,6 +202,7 @@ public enum MCConstants {
         "es.lproj", "es-ES.lproj", "es_ES.lproj", "es-MX.lproj", "es_MX.lproj", "es-419.lproj", "es_419.lproj",
         "es-US.lproj", "es_US.lproj", "Spanish.lproj",
         "pt.lproj", "pt-BR.lproj", "pt_BR.lproj", "Portuguese.lproj", "Portuguese (Brazil).lproj", "Brazilian Portuguese.lproj",
+        "ko.lproj", "ko-KR.lproj", "ko_KR.lproj", "Korean.lproj",
         "it.lproj", "it-IT.lproj", "it_IT.lproj", "it-CH.lproj", "it_CH.lproj", "Italian.lproj",
         "ja.lproj", "ja-JP.lproj", "ja_JP.lproj", "Japanese.lproj",
     ]
@@ -238,5 +239,5 @@ public enum MCConstants {
     // plugin was tried (commit history) but doesn't work under multi-arch
     // `swift build --arch arm64 --arch x86_64` because xcbuild doesn't
     // execute plugins.
-    public static let appVersion = "1.28.4"
+    public static let appVersion = "1.28.5"
 }

Tests/MacCleanKitTests/BatchCleanupLocalizationTests.swift

@@ -31,7 +31,7 @@ final class BatchCleanupLocalizationTests: AppLanguageTestCase {
         ]
         // These phrases are written identically in both Chinese scripts.
         let sameInTraditional: Set<String> = ["清理已停止", "完成", "清理完成"]
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .zhHant] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .zhHant] {
             AppLanguage.current = language
             for key in keys {
                 let value = L10n.tr(key, "MISSING_CLEANUP_TRANSLATION", "RU")

Tests/MacCleanKitTests/CleanupLocalizationTests.swift

@@ -14,7 +14,7 @@ final class CleanupLocalizationTests: AppLanguageTestCase {
     ]
 
     func testStaticCleanupCopyIsTranslatedForEveryDictionaryBackedLanguage() {
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .zhHant] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .zhHant] {
             AppLanguage.current = language
             for key in staticKeys {
                 let value = L10n.tr(key, "UNTRANSLATED", "Russian")
@@ -29,7 +29,7 @@ final class CleanupLocalizationTests: AppLanguageTestCase {
         AppLanguage.current = .en
         let english = [CleanupStrings.selectionSummary(selected: 2, total: 21),
                        CleanupStrings.confirmationTitle(count: 2), CleanupStrings.itemCount(2)]
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ru, .zhHans, .zhHant] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .ru, .zhHans, .zhHant] {
             AppLanguage.current = language
             let localized = [CleanupStrings.selectionSummary(selected: 2, total: 21),
                              CleanupStrings.confirmationTitle(count: 2), CleanupStrings.itemCount(2)]

Tests/MacCleanKitTests/HealthAlertsTests.swift

@@ -84,7 +84,7 @@ final class HealthAlertLocalizationTests: AppLanguageTestCase {
         let english = allStrings()
         AppLanguage.current = .zhHans
         let simplified = allStrings()
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko] {
             AppLanguage.current = language
             for (index, translated) in allStrings().enumerated() where index != swapLine {
                 XCTAssertNotEqual(translated, english[index], "\(language): \(english[index])")
@@ -97,7 +97,7 @@ final class HealthAlertLocalizationTests: AppLanguageTestCase {
     }
 
     func testPlaceholdersAreFilledInEveryLanguage() {
-        for language in [AppLanguage.en, .de, .fr, .it, .es, .ptBR, .ja, .ru, .zhHans, .zhHant] {
+        for language in [AppLanguage.en, .de, .fr, .it, .es, .ptBR, .ja, .ko, .ru, .zhHans, .zhHant] {
             AppLanguage.current = language
             let body = HealthAlertStrings.swapAlertBody(used: 6_800_000_000, threshold: 4_000_000_000)
             XCTAssertFalse(body.contains("{"), "\(language): \(body)")

Tests/MacCleanKitTests/LocalizationTests.swift

@@ -31,12 +31,49 @@ final class LocalizationTests: AppLanguageTestCase {
         }
     }
 
+    func testKoreanLanguageSelectionAndRegionalIdentifiers() {
+        XCTAssertTrue(AppLanguage.allCases.contains(.ko))
+        XCTAssertEqual(AppLanguage.ko.rawValue, "ko")
+        XCTAssertEqual(AppLanguage.ko.pickerLabel, "한국어")
+        XCTAssertEqual(AppLanguage.ko.localeIdentifier, "ko")
+        for identifier in ["ko", "ko-KR", "ko_KR", "KO-kr"] {
+            XCTAssertEqual(AppLanguage.preferredLanguage(for: identifier), .ko, identifier)
+        }
+    }
+
+    func testKoreanTranslationOverloadsAndFallbacks() {
+        AppLanguage.current = .ko
+        XCTAssertEqual(L10n.tr("设置", "Settings"), "설정")
+        XCTAssertEqual(L10n.tr("设置", "Settings", "Настройки"), "설정")
+        XCTAssertEqual(L10n.tr("设置"), "설정")
+        XCTAssertEqual(MaintenanceTask.freeUpRAM.title, "RAM 확보")
+        XCTAssertEqual(ScanCategory.userCaches.displayName, "사용자 캐시 파일")
+        XCTAssertEqual(FileListSort.sizeDescending.label, "큰 파일 먼저")
+        XCTAssertEqual(L10n.tr("未翻译", "New feature"), "New feature")
+        XCTAssertEqual(L10n.tr("未翻译", "New feature", "Russian"), "New feature")
+        XCTAssertEqual(L10n.tr("未翻译"), "未翻译")
+        for count in [1, 2] {
+            let english = "\(count) threat\(count == 1 ? "" : "s") found"
+            XCTAssertEqual(L10n.tr("发现 \(count) 个威胁", english), english)
+            XCTAssertEqual(L10n.tr("发现 \(count) 个威胁", english, "Russian"), english)
+        }
+    }
+
     func testBrazilianPortugueseLanguageResourcesCannotBeOfferedForCleanup() {
         for folder in ["pt.lproj", "pt-BR.lproj", "pt_BR.lproj", "Portuguese.lproj", "Portuguese (Brazil).lproj", "Brazilian Portuguese.lproj"] {
             XCTAssertTrue(LanguagePreferences.alwaysKept.contains(folder), folder)
         }
     }
 
+    func testKoreanLanguageResourcesCannotBeOfferedForCleanup() {
+        let original = LanguagePreferences.discoveredLproj
+        defer { LanguagePreferences.discoveredLproj = original }
+        let folders: Set<String> = ["ko.lproj", "ko-KR.lproj", "ko_KR.lproj", "Korean.lproj"]
+        LanguagePreferences.discoveredLproj = folders
+        XCTAssertTrue(folders.isSubset(of: LanguagePreferences.alwaysKept))
+        XCTAssertTrue(LanguagePreferences.selectableLanguages().isEmpty)
+    }
+
     func testGermanLanguageSelectionAndRegionalIdentifiers() {
         XCTAssertTrue(AppLanguage.allCases.contains(.de))
         XCTAssertEqual(AppLanguage.de.pickerLabel, "Deutsch")
@@ -264,7 +301,7 @@ final class LocalizationTests: AppLanguageTestCase {
             ("清除", "Clear", "Очистить"),
             ("这只会忘掉恢复记录，废纸篓里的文件不会被动。之后就不能一键恢复这些清理了。", "This only forgets the restore list. Nothing in the Trash is touched, but these cleans can no longer be restored in one click.", "Это"),
         ]
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko] {
             AppLanguage.current = language
             for (zh, en, ru) in strings {
                 let value = L10n.tr(zh, en, ru)
@@ -380,6 +417,7 @@ final class LocalizationTests: AppLanguageTestCase {
             .es: "Invítame a un café",
             .ptBR: "Me pague um café",
             .ja: "コーヒーをおごる",
+            .ko: "커피 한 잔 후원하기",
             .zhHant: "請我喝杯咖啡",
             .ru: "Угостить кофе",
         ]
@@ -401,7 +439,7 @@ final class LocalizationTests: AppLanguageTestCase {
         let sameAsSimplified: Set<String> = [
             "容器", "卷", "大小", "取消", "永久清理", "清理完成", "未能完成", "已停止",
         ]
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ru] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .ru] {
             AppLanguage.current = language
             for (index, value) in DiskHogsText.all.enumerated() where !sameAsEnglish.contains(english[index]) || language == .ru {
                 XCTAssertNotEqual(value, english[index], "\(language) is missing: \(english[index])")
@@ -431,7 +469,7 @@ final class LocalizationTests: AppLanguageTestCase {
             ("正在查找项目…", "Finding projects…", "Поиск проектов…"),
             ("正在计算文件夹大小…", "Measuring folders…", "Подсчёт размера папок…"),
         ]
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .zhHant, .ru] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .zhHant, .ru] {
             AppLanguage.current = language
             for s in strings {
                 let text = L10n.tr(s.zh, s.en, s.ru)
@@ -475,7 +513,7 @@ final class LocalizationTests: AppLanguageTestCase {
         let sameInTraditional: Set<String> = ["未知"]
 
         for (zh, english) in strings {
-            for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja] {
+            for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko] {
                 AppLanguage.current = language
                 XCTAssertNotEqual(L10n.tr(zh, english), english, "\(language) is missing \"\(english)\"")
             }

Tests/MacCleanKitTests/SupportersTests.swift

@@ -64,7 +64,7 @@ final class SupporterStringsTests: AppLanguageTestCase {
         let english = allStrings()
         AppLanguage.current = .zhHans
         let simplified = allStrings()
-        for language in [AppLanguage.de, .fr, .it, .ru, .ja, .ptBR, .es] {
+        for language in [AppLanguage.de, .fr, .it, .ru, .ko, .ja, .ptBR, .es] {
             AppLanguage.current = language
             for (index, translated) in allStrings().enumerated() {
                 XCTAssertNotEqual(translated, english[index], "\(language): \(english[index])")
@@ -77,7 +77,7 @@ final class SupporterStringsTests: AppLanguageTestCase {
     }
 
     func testPlaceholderIsFilledInEveryLanguage() {
-        for language in [AppLanguage.en, .de, .fr, .it, .ru, .zhHans, .zhHant, .ja, .ptBR, .es] {
+        for language in [AppLanguage.en, .de, .fr, .it, .ru, .zhHans, .zhHant, .ko, .ja, .ptBR, .es] {
             AppLanguage.current = language
             let caption = SupporterStrings.caption(for: ["Ada"])
             XCTAssertTrue(caption.contains("Ada"), "\(language): \(caption)")

Tests/MacCleanTests/BrowserExtensionsLocalizationTests.swift

@@ -56,7 +56,7 @@ final class BrowserExtensionsLocalizationTests: EnglishAppLanguageTestCase {
         AppLanguage.current = .zhHans
         let simplified = allStrings()
 
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ru] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .ru] {
             AppLanguage.current = language
             for (index, value) in allStrings().enumerated() {
                 XCTAssertNotEqual(value, english[index], "\(language) is untranslated: \(english[index])")
@@ -70,7 +70,7 @@ final class BrowserExtensionsLocalizationTests: EnglishAppLanguageTestCase {
     }
 
     func testNoEmDashesOrUnfilledPlaceholders() {
-        for language in [AppLanguage.en, .de, .fr, .it, .es, .ptBR, .ja, .ru, .zhHans, .zhHant] {
+        for language in [AppLanguage.en, .de, .fr, .it, .es, .ptBR, .ja, .ko, .ru, .zhHans, .zhHant] {
             AppLanguage.current = language
             for value in allStrings() {
                 XCTAssertFalse(value.contains("\u{2014}"), "\(language) has an em dash: \(value)")

Tests/MacCleanTests/LaunchAtLoginErrorLocalizationTests.swift

@@ -26,6 +26,7 @@ final class LaunchAtLoginErrorLocalizationTests: EnglishAppLanguageTestCase {
             (.ptBR, "Não foi possível ativar a abertura ao iniciar sessão: MSG",
              "Não foi possível desativar a abertura ao iniciar sessão: MSG"),
             (.ja, "ログイン時に起動をオンにできませんでした：MSG", "ログイン時に起動をオフにできませんでした：MSG"),
+            (.ko, "로그인 시 실행을 켤 수 없음: MSG", "로그인 시 실행을 끌 수 없음: MSG"),
             (.ru, "Не удалось включить запуск при входе: MSG", "Не удалось отключить запуск при входе: MSG"),
             (.zhHans, "无法开启登录时启动：MSG", "无法关闭登录时启动：MSG"),
             (.zhHant, "無法開啟登入時啟動：MSG", "無法關閉登入時啟動：MSG"),

Tests/MacCleanTests/MalwareLocalizationTests.swift

@@ -61,7 +61,7 @@ final class MalwareLocalizationTests: EnglishAppLanguageTestCase {
         AppLanguage.current = .zhHans
         let simplified = allStrings()
 
-        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ru] {
+        for language in [AppLanguage.de, .fr, .it, .es, .ptBR, .ja, .ko, .ru] {
             AppLanguage.current = language
             for (index, value) in allStrings().enumerated() {
                 XCTAssertNotEqual(value, english[index], "\(language) is untranslated: \(english[index])")

VERSION

@@ -1 +1 @@
-1.28.4
+1.28.5

scripts/build-dmg.sh

@@ -110,6 +110,7 @@ cat > "${APP_BUNDLE}/Contents/Info.plist" << PLIST
         <string>es</string>
         <string>pt-BR</string>
         <string>ja</string>
+        <string>ko</string>
     </array>
     <key>CFBundleExecutable</key>
     <string>MacClean</string>
@@ -189,6 +190,7 @@ cat > "${MENU_APP}/Contents/Info.plist" << MENU_PLIST
         <string>es</string>
         <string>pt-BR</string>
         <string>ja</string>
+        <string>ko</string>
     </array>
     <key>CFBundleExecutable</key>
     <string>MacCleanMenu</string>