Skip to content

Preserve runner Docker settings in isolated CI configuration - #67

Draft
peterd-NV wants to merge 1 commit into
mainfrom
peterd/fix_ci_docker_network_config
Draft

Preserve runner Docker settings in isolated CI configuration#67
peterd-NV wants to merge 1 commit into
mainfrom
peterd/fix_ci_docker_network_config

Conversation

@peterd-NV

@peterd-NV peterd-NV commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Update the pre-merge and nightly to preserve the runner’s docker client
configuration while still to isolating jobs from stale Docker credentials.

CI previously used an empty temporary docker config to prevent stale NVCR credentials from
affecting image pulls. However, this also discarded non-authentication settings from the
runner, including proxy and buildx configuration needed for reliable package downloads during
Docker builds.

Workflows now:

  • Copy the runner’s existing Docker configuration into a job-temporary directory.
  • Remove auths, credsStore, and credHelpers from the copied configuration.
  • Preserve proxy, buildx, and other non-authentication settings.
  • Avoid reading from or modifying the runner’s persistent Docker login during the build.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 9d66fff5-84a3-4c82-ad88-10cdb1d117f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@peterd-NV peterd-NV changed the title [TEST] preserve docker configs other than credentials Preserve runner Docker settings in isolated CI configuration Aug 18, 2026
cp -a "${HOME}/.docker/." "${DOCKER_CONFIG}/"
fi
if [ -f "${DOCKER_CONFIG}/config.json" ]; then
jq 'del(.auths, .credsStore, .credHelpers)' \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this if you are doing the cusstom folder in line 67. the docker comand should use the docker config file though, using --config ${DOCKER_CONFIG} or so

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the copy here is intentional for preserving the runner’s proxy/build settings while removing any login credentials that was causing the image pull failure. The empty config was potentially causing network failures during Docker builds so this one puts any existing network configs back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants