Preserve runner Docker settings in isolated CI configuration - #67
Preserve runner Docker settings in isolated CI configuration#67peterd-NV wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
| cp -a "${HOME}/.docker/." "${DOCKER_CONFIG}/" | ||
| fi | ||
| if [ -f "${DOCKER_CONFIG}/config.json" ]; then | ||
| jq 'del(.auths, .credsStore, .credHelpers)' \ |
There was a problem hiding this comment.
I don't think you need this if you are doing the cusstom folder in line 67. the docker comand should use the docker config file though, using --config ${DOCKER_CONFIG} or so
There was a problem hiding this comment.
I think the copy here is intentional for preserving the runner’s proxy/build settings while removing any login credentials that was causing the image pull failure. The empty config was potentially causing network failures during Docker builds so this one puts any existing network configs back in.
Summary
Update the pre-merge and nightly to preserve the runner’s docker client
configuration while still to isolating jobs from stale Docker credentials.
CI previously used an empty temporary docker config to prevent stale NVCR credentials from
affecting image pulls. However, this also discarded non-authentication settings from the
runner, including proxy and buildx configuration needed for reliable package downloads during
Docker builds.
Workflows now: