Skip to content

Preserve runner Docker settings in isolated CI configuration #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
peterd-NV wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Preserve runner Docker settings in isolated CI configuration #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,21 @@ jobs:
git lfs pull

- name: Run E2E tests
# The GPU runners are shared. Use an empty job-temporary Docker config so
# stale credentials cannot override anonymous access to the public base image,
# and this job cannot modify the runner's persistent Docker login.
# The GPU runners are shared. Preserve their Docker client settings (for
# example proxy and buildx configuration) in a job-temporary copy, but
# remove all credential sources so stale logins cannot affect this job.
env:
DOCKER_CONFIG: ${{ runner.temp }}/isaac-autodata-docker
run: |
mkdir -p "${DOCKER_CONFIG}"
if [ -d "${HOME}/.docker" ]; then
cp -a "${HOME}/.docker/." "${DOCKER_CONFIG}/"
fi
if [ -f "${DOCKER_CONFIG}/config.json" ]; then
jq 'del(.auths, .credsStore, .credHelpers)' \
"${DOCKER_CONFIG}/config.json" > "${DOCKER_CONFIG}/config.sanitized.json"
mv "${DOCKER_CONFIG}/config.sanitized.json" "${DOCKER_CONFIG}/config.json"
fi
./scripts/ci/run_tests.sh

build_docs:
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,21 @@ jobs:
git lfs pull

- name: Run full E2E suite
# The GPU runners are shared. Use an empty job-temporary Docker config so
# stale credentials cannot override anonymous access to the public base image,
# and this job cannot modify the runner's persistent Docker login.
# The GPU runners are shared. Preserve their Docker client settings (for
# example proxy and buildx configuration) in a job-temporary copy, but
# remove all credential sources so stale logins cannot affect this job.
env:
DOCKER_CONFIG: ${{ runner.temp }}/isaac-autodata-docker
run: |
mkdir -p "${DOCKER_CONFIG}"
if [ -d "${HOME}/.docker" ]; then
cp -a "${HOME}/.docker/." "${DOCKER_CONFIG}/"
fi
if [ -f "${DOCKER_CONFIG}/config.json" ]; then
jq 'del(.auths, .credsStore, .credHelpers)' \

@hguillen hguillen Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this if you are doing the cusstom folder in line 67. the docker comand should use the docker config file though, using --config ${DOCKER_CONFIG} or so

@peterd-NV peterd-NV Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the copy here is intentional for preserving the runner’s proxy/build settings while removing any login credentials that was causing the image pull failure. The empty config was potentially causing network failures during Docker builds so this one puts any existing network configs back in.

"${DOCKER_CONFIG}/config.json" > "${DOCKER_CONFIG}/config.sanitized.json"
mv "${DOCKER_CONFIG}/config.sanitized.json" "${DOCKER_CONFIG}/config.json"
fi
./scripts/ci/run_tests.sh

- name: Test results summary
Expand Down
Loading