Declare the 200 that quote and transfer creation answer - #1112
Conversation
POST /quotes, /transfer-in and /transfer-out have always answered 200 for a newly created quote or transfer; the spec declared 201. The 202 for a quote awaiting Strong Customer Authentication stays. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
|
| `POST /quotes`, `POST /transfer-in` and `POST /transfer-out` have always answered | ||
| `200 OK` for a newly created quote or transfer, and the spec now says so instead of | ||
| `201 Created`. The `202 Accepted` reply for a quote awaiting Strong Customer |
There was a problem hiding this comment.
Quote examples still say 201
The changelog now says POST /quotes returns 200, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses 201 Created. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.
Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/changelog.mdx
Line: 15-17
Comment:
**Quote examples still say 201**
The changelog now says `POST /quotes` returns `200`, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses `201 Created`. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
The three guide examples that create a quote labelled the response 201 Created; the operation answers 200. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7
POST /quotes,POST /transfer-inandPOST /transfer-outhave always answered200 OKfor a newly created quote or transfer; the spec declared201 Created. The spec now matches the server. The202 Acceptedreply for a quote awaiting Strong Customer Authentication stays as declared.Also updates the status table in the error-handling snippet, which listed quotes and transactions under 201, and adds a changelog entry.
These are the last three entries in sparkcore's handler conformance test; once this bumps into webdev the exception list goes.
make buildandmake lintpass.make lint-markdownfails on main as well (thelint:markdownnpm script is missing).🤖 Generated with Claude Code
https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7
Generated by Claude Code