Skip to content

Declare the 200 that quote and transfer creation answer - #1112

Merged
shreyav merged 2 commits into
mainfrom
claude/awesome-davinci-zlf3oa-create-statuses
Oct 2, 2026
Merged

shreyav merged 2 commits into
mainfrom
claude/awesome-davinci-zlf3oa-create-statuses

Conversation

@shreyav

@shreyav shreyav commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

POST /quotes, POST /transfer-in and POST /transfer-out have always answered 200 OK for a newly created quote or transfer; the spec declared 201 Created. The spec now matches the server. The 202 Accepted reply for a quote awaiting Strong Customer Authentication stays as declared.

Also updates the status table in the error-handling snippet, which listed quotes and transactions under 201, and adds a changelog entry.

These are the last three entries in sparkcore's handler conformance test; once this bumps into webdev the exception list goes.

make build and make lint pass. make lint-markdown fails on main as well (the lint:markdown npm script is missing).

🤖 Generated with Claude Code

https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7


Generated by Claude Code

POST /quotes, /transfer-in and /transfer-out have always answered 200 for a
newly created quote or transfer; the spec declared 201. The 202 for a quote
awaiting Strong Customer Authentication stays.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7
@mintlify

mintlify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Oct 2, 2026, 5:33 PM

@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Preview Oct 2, 2026 5:32pm UTC
grid-flow-builder Ignored Ignored Preview Oct 2, 2026 5:32pm UTC
grid-wallet-demo Ignored Ignored Preview Oct 2, 2026 5:32pm UTC

Request Review

@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

oasdiff reports 3 error / 0 warning changes to openapi.yaml.
This PR will need approval from an API reviewer before merge.

Errors (3)

  • POST /quotes — removed the success response with the status 201 [response-success-status-removed].
  • POST /transfer-in — removed the success response with the status 201 [response-success-status-removed].
  • POST /transfer-out — removed the success response with the status 201 [response-success-status-removed].

Detected by oasdiff. Full report: job summary or the oasdiff-report artifact.

@greptile-apps

greptile-apps Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Critical risk] Changes the public API contract for quote and transfer endpoints.

The PR appears safe to merge, though the remaining quote examples should be corrected to avoid conflicting guidance.

Findings

  1. P2 Quote examples still say 201 ▶
Fix with agent prompt
### Issue 1
mintlify/changelog.mdx:15-17
The changelog now says `POST /quotes` returns `200`, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses `201 Created`. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR changes the declared successful response for quote, transfer-in, and transfer-out creation from 201 to 200 in the modular OpenAPI paths and both bundles.

  • It updates the shared status table and adds a changelog entry.
  • Three quote-creation examples still show 201 and should be aligned with the corrected contract.

Reviews (1) · Last reviewed commit: "Declare the 200 that quote and transfer ..."

Comment thread mintlify/changelog.mdx
Comment on lines +15 to +17
`POST /quotes`, `POST /transfer-in` and `POST /transfer-out` have always answered
`200 OK` for a newly created quote or transfer, and the spec now says so instead of
`201 Created`. The `202 Accepted` reply for a quote awaiting Strong Customer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Quote examples still say 201
The changelog now says POST /quotes returns 200, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses 201 Created. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.

Prompt To Fix With AI
This is a comment left during a code review.
Path: mintlify/changelog.mdx
Line: 15-17

Comment:
**Quote examples still say 201**
The changelog now says `POST /quotes` returns `200`, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses `201 Created`. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

The three guide examples that create a quote labelled the response 201
Created; the operation answers 200.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KYyhvyVNjMMDrKJqFriCE7
@shreyav
shreyav merged commit 9516962 into main Oct 2, 2026
8 checks passed
@shreyav
shreyav deleted the claude/awesome-davinci-zlf3oa-create-statuses branch October 2, 2026 17:49

This branch was successfully deployed

1 active deployment
staging - mintlify — 8cb3514b Deployed Oct 2, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Introduces a breaking change to the OpenAPI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants