Skip to content

Declare the 200 that quote and transfer creation answer #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreyav merged 2 commits into from
Oct 2, 2026
+24 −13
Merged

Declare the 200 that quote and transfer creation answer #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cf6f79
Declare the 200 that quote and transfer creation answer
claude Oct 2, 2026
8cb3514
Label the quote examples 200 OK
claude Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mintlify/changelog.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,17 @@ mode: "wide"
Follow along with the latest additions and improvements to the Grid API. For upcoming
changes and roadmap, [contact our team](https://www.lightspark.com/contact).

<Update label="October 2026">

## Quote and transfer creation answer `200`

`POST /quotes`, `POST /transfer-in` and `POST /transfer-out` have always answered
`200 OK` for a newly created quote or transfer, and the spec now says so instead of
`201 Created`. The `202 Accepted` reply for a quote awaiting Strong Customer
Comment on lines +15 to +17

@greptile-apps greptile-apps Bot Oct 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Quote examples still say 201
The changelog now says POST /quotes returns 200, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses 201 Created. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: mintlify/changelog.mdx
Line: 15-17

Comment:
**Quote examples still say 201**
The changelog now says `POST /quotes` returns `200`, but the account-payment and crypto-funding snippets and the payout guide still label successful quote responses `201 Created`. These conflicting examples make it unclear which status readers should expect. Please align them with the corrected contract.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Authentication is unchanged.

</Update>

<Update label="September 2026">

## Sandbox test suffixes work on Solana addresses
Expand Down
6 changes: 3 additions & 3 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mintlify/payouts-and-b2b/payment-flow/send-payment.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/quotes' \
}'
```

```json Success (201 Created)
```json Success (200 OK)
{
"id": "Quote:019542f5-b3e7-1d02-0000-000000000025",
"status": "PENDING",
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/error-handling.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Grid uses standard HTTP status codes to indicate the success or failure of reque
| Status Code | Meaning | When It Occurs |
| --------------------------- | ----------------------- | ------------------------------------------------------- |
| `200 OK` | Success | Request completed successfully |
| `201 Created` | Resource created | New transaction, quote, or customer created |
| `201 Created` | Resource created | New customer, account, or credential created |
| `202 Accepted` | Accepted for processing | Async operation initiated (e.g., bulk CSV upload) |
| `400 Bad Request` | Invalid input | Missing required fields or invalid parameters |
| `401 Unauthorized` | Authentication failed | Invalid or missing API credentials |
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/sending/accounts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/quotes' \
}'
```

```json Success (201 Created)
```json Success (200 OK)
{
"id": "Quote:019542f5-b3e7-1d02-0000-000000000025",
"status": "PENDING",
Expand Down
2 changes: 1 addition & 1 deletion mintlify/snippets/sending/crypto-funding.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ curl -X POST 'https://api.lightspark.com/grid/2025-10-13/quotes' \

The response includes an array of payment instructions, including blockchain wallet addresses for USDC and invoices for BTC:

```json Success (201 Created)
```json Success (200 OK)
{
"id": "Quote:019542f5-b3e7-1d02-0000-000000000025",
"status": "PENDING",
Expand Down
6 changes: 3 additions & 3 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi/paths/quotes/quotes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ post:
- PaymentDocument:019542f5-b3e7-1d02-0000-000000000003
description: 'Accounting services, invoice INV-2025-0142'
responses:
'201':
'200':
description: |
Transfer quote created successfully. The response includes exchange rates,
fees, and transfer details. For transfers involving UMA addresses, payment
Expand Down
2 changes: 1 addition & 1 deletion openapi/paths/transfers/transfer_in.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ post:
accountId: InternalAccount:a12dcbd6-dced-4ec4-b756-3c3a9ea3d123
amount: 12550
responses:
'201':
'200':
description: Transfer-in request created successfully
content:
application/json:
Expand Down
2 changes: 1 addition & 1 deletion openapi/paths/transfers/transfer_out.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ post:
amount: 12550
remittanceInformation: '12345'
responses:
'201':
'200':
description: >
Transfer-out request created successfully.
content:
Expand Down
Loading