Repository navigation
Name a statement receipt's period by its month - #1134
Closed
ls-bolt[bot] wants to merge 2 commits into
Closed
ls-bolt[bot] wants to merge 2 commits into
ls-bolt[bot] wants to merge 2 commits into
Conversation
statementMonth (YYYY-MM) replaces periodStart on confirm-statement, so a receipt states the month it covers instead of a date that must be the first. Co-Authored-By: gcamata <gcamata@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Author
|
@greptile review |
Contributor
|
Contributor
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
benwgold
marked this pull request as ready for review
October 8, 2026 07:17
benwgold
added a commit
that referenced
this pull request
Oct 9, 2026
## Summary
- `POST /internal-accounts/{id}/confirm-statement` takes
`statementMonth` (`YYYY-MM`) in place of `periodStart`, and
`StatementDelivery` returns it the same way.
- A statement covers a calendar month, so the receipt names that month.
The old field was a date that had to be the first of the month.
- Updated the endpoint's 400 text, the Periodic Statements tag
description, and the statements guide example.
- `GET /internal-accounts/{id}/balance-changes`: `BalanceChange` no
longer has a `fee` field. One transaction can produce several balance
changes (a withdrawal's fee posted beside its payout, a debit and its
refund), so a per-line fee had to pick a line and could count the fee
twice. A fee is already inside `amount`, and `fees` on `GET
/transactions/{id}` gives it once per transaction. The endpoint
description, the statements guide's total-fees row and example code (the
separate fee-line-items row is gone), and the guide drops the
ATM-surcharge note, and the changelog now take the period's fees from
the transactions.
- `GET /internal-accounts/{id}/balance-changes`: the `cursor`
description now says to send it unchanged with the same account,
`startDate` and `endDate` as the page that issued it. A cursor does not
expire, so a platform can pause between pages. The 400 text covers a
cursor issued for another account or window.
## Compatibility
This changes the request and response shape of `confirm-statement` and
drops `fee` from `BalanceChange`. Both endpoints are new, and no
integrator calls them yet.
## Test plan
- `make build`, `make lint`: the spec bundles and lints clean (only
pre-existing warnings).
- `node --check` on the statements guide's example code.
Requested by @benwgold
Original PR: #1134
---------
Co-authored-by: gcamata <gcamata@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-authored-by: benwgold <benwgold@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
POST /internal-accounts/{id}/confirm-statementtakesstatementMonth(YYYY-MM) in place ofperiodStart, andStatementDeliveryreturns it the same way.GET /internal-accounts/{id}/balance-changes: thecursordescription now says to send it unchanged with the same account,startDateandendDateas the page that issued it, and that it expires after 24 hours. The 400 text covers a cursor issued for another window, or one that has expired.Compatibility
This changes the request and response shape of
confirm-statement. The endpoint is new, and no integrator sends receipts yet.Test plan
make build,make lint-openapi: the spec bundles and lints clean (only pre-existing warnings).Requested by @benwgold