Repository navigation
Name a statement receipt's period by its month - #1144
Merged
Merged
Conversation
statementMonth (YYYY-MM) replaces periodStart on confirm-statement, so a receipt states the month it covers instead of a date that must be the first. Co-Authored-By: gcamata <gcamata@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ls-bolt
Bot
added
bolt
breaking-change
Contributor
|
This PR does not match any of the 3 configured review trigger rules. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
benwgold
marked this pull request as ready for review
October 8, 2026 07:20
Contributor
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
ls-bolt
Bot
force-pushed
the
10-07-statement-month
branch
from
October 8, 2026 23:14
c4115dd to
a7388ff
Compare
…m balance changes Drop fee from BalanceChange. A fee belongs to a transaction, and one transaction can produce several balance changes. The statements guide now totals a period's fees from each transaction's fees, counted once: charged in the period that holds the transaction's debit and given back in the period that holds its refund credit. The example lists fees as their own disclosure lines. Co-Authored-By: benwgold <benwgold@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ls-bolt
Bot
force-pushed
the
10-07-statement-month
branch
from
October 8, 2026 23:14
a7388ff to
0ec536c
Compare
gcamata
reviewed
Oct 8, 2026
| statementMonth: | ||
| type: string | ||
| format: date | ||
| pattern: '^\d{4}-(0[1-9]|1[0-2])$' |
Contributor
|
🦣 Congratulations @gcamata - your substantive review earned a Valgipes! (common)
View your Frost-dex: https://zeus.dev.dev.sparkinfra.net/#/dinodex/gcamata?section=ice-age |
Co-Authored-By: gcamata <gcamata@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
benwgold
enabled auto-merge (squash)
October 9, 2026 00:09
AaryamanBhute
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /internal-accounts/{id}/confirm-statementtakesstatementMonth(YYYY-MM) in place ofperiodStart, andStatementDeliveryreturns it the same way.GET /internal-accounts/{id}/balance-changes:BalanceChangeno longer has afeefield. One transaction can produce several balance changes (a withdrawal's fee posted beside its payout, a debit and its refund), so a per-line fee had to pick a line and could count the fee twice. A fee is already insideamount, andfeesonGET /transactions/{id}gives it once per transaction. The endpoint description, the statements guide's total-fees row and example code (the separate fee-line-items row is gone), and the guide drops the ATM-surcharge note, and the changelog now take the period's fees from the transactions.GET /internal-accounts/{id}/balance-changes: thecursordescription now says to send it unchanged with the same account,startDateandendDateas the page that issued it. A cursor does not expire, so a platform can pause between pages. The 400 text covers a cursor issued for another account or window.Compatibility
This changes the request and response shape of
confirm-statementand dropsfeefromBalanceChange. Both endpoints are new, and no integrator calls them yet.Test plan
make build,make lint: the spec bundles and lints clean (only pre-existing warnings).node --checkon the statements guide's example code.Requested by @benwgold
Original PR: #1134