Skip to content

Fix fallback limits for prismatic joints in Ruckig smoothing - #3783

Open
nk-pavan-official wants to merge 1 commit into
moveit:mainfrom
nk-pavan-official:fix/prismatic-joint-units
Open

Fix fallback limits for prismatic joints in Ruckig smoothing#3783
nk-pavan-official wants to merge 1 commit into
moveit:mainfrom
nk-pavan-official:fix/prismatic-joint-units

Conversation

@nk-pavan-official

@nk-pavan-official nk-pavan-official commented Jul 7, 2026

Copy link
Copy Markdown

Description

This PR fixes the fallback limits used for prismatic joints when joint limits are not defined.

Previously, prismatic joints used the same default values as revolute joints, which are in angular units. This could result in incorrect fallback limits for linear joints.

This PR:

*Adds separate default limits for prismatic joints.
*Selects the correct fallback based on the joint type.
*Updates the warning messages with the correct units.
*Adds tests to verify the new behavior.

Fixes #3781

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@nk-pavan-official

Copy link
Copy Markdown
Author

I have opened a PR for this issue: #3783

Looking forward to any feedback. Thanks!
#3783 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit safety issue: Angular default acceleration applied to prismatic joints

1 participant