Repository navigation
Carry a Spent Budget's Body-Listed Findings Through the Merge Gate - #2631
Conversation
`drive-pr` "The Drive Loop" step 2 now writes each `introduced` finding still open after a spent `local-strict-review` edit budget into the pull request's body with its class, adding to any list already there. `pr-review-conduct` Merge Gate item 3 now names a body-listed finding as needing an outcome before merge, whichever head it was found on, and records that outcome in a pull request comment, since such a finding has no thread. The generated skill copies are rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Merge Gate paragraph now points a body-listed finding's answer at "Answering a suppressed finding" rather than stating a looser format, and the new sentences in both skills are split to the word cap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Answering a suppressed finding" gains `Deferred to <issue>` and `Awaiting maintainer` verdicts, so outcomes 3 and 4 each have one, and its run-on opening sentence is split. The body-listed paragraph maps that section's `(N)` count to the list's length, and drive-pr's citation moves back to the sentence that writes the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
"Answering a suppressed finding" now says an `Awaiting maintainer` answer leaves the finding open until a later answer records the maintainer's decision, and the body-listed paragraph defers to it rather than restating outcome 3's open state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Body-listed local review findings (1), from the "Remaining local review findings" list in this pull request's body:
|
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical issues prevent reliable detection and disposition of body-listed findings.
2 open findings
What changed in this PR
Carries spent local-review findings into pull-request bodies and merge-gate procedures, with regenerated skill distributions.
Changes:
- Adds body-listed finding handling to the drive loop and merge gate.
- Adds deferred and maintainer-awaiting verdicts.
- Rebuilds generated skill copies and source digests.
| File | Summary |
|---|---|
.github/skills/pr-review-conduct/SKILL.md |
Generated review-conduct copy. |
.github/skills/drive-pr/SKILL.md |
Generated drive-loop copy. |
.claude-plugin/fleet-skills/skills/pr-review-conduct/SKILL.md |
Generated Claude skill copy. |
.claude-plugin/fleet-skills/skills/drive-pr/SKILL.md |
Generated Claude skill copy. |
.claude-plugin/fleet-skills/.source-digests/pr-review-conduct |
Updated source digest. |
.claude-plugin/fleet-skills/.source-digests/drive-pr |
Updated source digest. |
.agents/skills/pr-review-conduct/SKILL.md |
Critical findings: body-listed findings are not read by the gate tooling, and outcome 5 lacks a defined verdict (1 vote each). |
.agents/skills/drive-pr/SKILL.md |
Nit: define the body block format and preservation behavior (1 vote). |
🧠 Review effort: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2631 +/- ##
========================================
Coverage 59.34% 59.34%
========================================
Files 16 16
Lines 8282 8282
========================================
Hits 4915 4915
Misses 3367 3367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merge Gate item 3 now says `pr_review.py status` and `wait` do not read the pull request's body, so the gate reads the body live for its remaining-findings list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Correction to #2631 (comment): that reply retyped the fixing commit's SHA by hand and named a commit that does not exist. The finding ("Make the gate read body-listed findings") is Fixed in 431de37. Merge Gate item 3's body-listed paragraph now says |
|
A recorded local strict-review pass covers head |
|
Answering the finding the Copilot round on 68e2a43 named only in its file table (1), outside its two threads:
|
Promotes the one change develop holds over main: `drive-pr` writes a spent edit budget's remaining `introduced` findings into the pull request body, `pr-review-conduct`'s Merge Gate gives each body-listed finding an outcome answered as a suppressed finding, and that section gains `Deferred to <issue>` and `Awaiting maintainer` verdicts (#2631). Fixes #2613 🤖 Generated with [Claude Code](https://claude.com/claude-code)

local-strict-review"Disposing of Findings" hands eachintroducedfinding still open after a spent edit budget to the pull request, listed in its body. Nothing on the path to the merge carried that list, so this carries it through.drive-pr"The Drive Loop" step 2 now writes eachintroducedfinding still open after a spent budget into the pull request's body with its class. A later push adds its own to any list already there.pr-review-conductMerge Gate item 3 now names a body-listed finding as needing an outcome before merge, whichever head it was found on. It has no thread, so it is answered as "Answering a suppressed finding" states, citing the body's list and its length.Deferred to <issue>andAwaiting maintainerverdicts, so outcomes 3 and 4 each have one. Its run-on opening sentence is split.build_dist.py, andbuild_dist.py --checkis clean.Remaining local review findings
This push spent its two-round edit budget with this finding still open. The review loop gives it an outcome before merge.
introduced:.agents/skills/pr-review-conduct/SKILL.md"Answering a suppressed finding" allows anAwaiting maintainerverdict but does not say that posting it leaves the finding open. Merge Gate item 3 reads a suppressed finding as closed once "investigated and answered", so that verdict alone would satisfy item 3 while outcome 3's value call is still pending.Closes on promotion: #2613
🤖 Generated with Claude Code