Skip to content

Carry a Spent Budget's Body-Listed Findings Through the Merge Gate - #2631

Merged
ptr727 merged 6 commits into
developfrom
feature/auto-2613
Oct 9, 2026
Merged

ptr727 merged 6 commits into
developfrom
feature/auto-2613

Conversation

@ptr727

@ptr727 ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner

local-strict-review "Disposing of Findings" hands each introduced finding still open after a spent edit budget to the pull request, listed in its body. Nothing on the path to the merge carried that list, so this carries it through.

  • drive-pr "The Drive Loop" step 2 now writes each introduced finding still open after a spent budget into the pull request's body with its class. A later push adds its own to any list already there.
  • pr-review-conduct Merge Gate item 3 now names a body-listed finding as needing an outcome before merge, whichever head it was found on. It has no thread, so it is answered as "Answering a suppressed finding" states, citing the body's list and its length.
  • "Answering a suppressed finding" gains Deferred to <issue> and Awaiting maintainer verdicts, so outcomes 3 and 4 each have one. Its run-on opening sentence is split.
  • The generated copies are rebuilt with build_dist.py, and build_dist.py --check is clean.

Remaining local review findings

This push spent its two-round edit budget with this finding still open. The review loop gives it an outcome before merge.

  1. introduced: .agents/skills/pr-review-conduct/SKILL.md "Answering a suppressed finding" allows an Awaiting maintainer verdict but does not say that posting it leaves the finding open. Merge Gate item 3 reads a suppressed finding as closed once "investigated and answered", so that verdict alone would satisfy item 3 while outcome 3's value call is still pending.

Closes on promotion: #2613

🤖 Generated with Claude Code

ptr727 and others added 3 commits October 8, 2026 23:31
`drive-pr` "The Drive Loop" step 2 now writes each `introduced`
finding still open after a spent `local-strict-review` edit budget into
the pull request's body with its class, adding to any list already
there. `pr-review-conduct` Merge Gate item 3 now names a body-listed
finding as needing an outcome before merge, whichever head it was found
on, and records that outcome in a pull request comment, since such a
finding has no thread. The generated skill copies are rebuilt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Merge Gate paragraph now points a body-listed finding's answer at
"Answering a suppressed finding" rather than stating a looser format,
and the new sentences in both skills are split to the word cap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"Answering a suppressed finding" gains `Deferred to <issue>` and
`Awaiting maintainer` verdicts, so outcomes 3 and 4 each have one, and
its run-on opening sentence is split. The body-listed paragraph maps that
section's `(N)` count to the list's length, and drive-pr's citation
moves back to the sentence that writes the list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 9, 2026 06:41
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: ptr727/ProjectTemplate/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 754a44a6-5c7e-4e42-bb5d-f48a74e3933b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

"Answering a suppressed finding" now says an `Awaiting maintainer`
answer leaves the finding open until a later answer records the
maintainer's decision, and the body-listed paragraph defers to it rather
than restating outcome 3's open state.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Body-listed local review findings (1), from the "Remaining local review findings" list in this pull request's body:

  1. introduced, .agents/skills/pr-review-conduct/SKILL.md "Answering a suppressed finding": "allows an Awaiting maintainer verdict but does not say that posting it leaves the finding open." Fixed in 7bc6564. The section now says an Awaiting maintainer answer leaves the finding open until a later answer records the maintainer's decision. A local strict-review pass over the full diff at that head found nothing further.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved critical issues prevent reliable detection and disposition of body-listed findings.

2 open findings
What changed in this PR

Carries spent local-review findings into pull-request bodies and merge-gate procedures, with regenerated skill distributions.

Changes:

  • Adds body-listed finding handling to the drive loop and merge gate.
  • Adds deferred and maintainer-awaiting verdicts.
  • Rebuilds generated skill copies and source digests.
File Summary
.github/​skills/​pr-review-conduct/​SKILL.md Generated review-conduct copy.
.github/​skills/​drive-pr/​SKILL.md Generated drive-loop copy.
.claude-plugin/​fleet-skills/​skills/​pr-review-conduct/​SKILL.md Generated Claude skill copy.
.claude-plugin/​fleet-skills/​skills/​drive-pr/​SKILL.md Generated Claude skill copy.
.claude-plugin/​fleet-skills/​.source-digests/​pr-review-conduct Updated source digest.
.claude-plugin/​fleet-skills/​.source-digests/​drive-pr Updated source digest.
.agents/​skills/​pr-review-conduct/​SKILL.md Critical findings: body-listed findings are not read by the gate tooling, and outcome 5 lacks a defined verdict (1 vote each).
.agents/​skills/​drive-pr/​SKILL.md Nit: define the body block format and preservation behavior (1 vote).

🧠 Review effort: Lite


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .agents/skills/pr-review-conduct/SKILL.md Outdated
Comment thread .agents/skills/pr-review-conduct/SKILL.md Outdated
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.34%. Comparing base (0788603) to head (40e11b8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2631   +/-   ##
========================================
  Coverage    59.34%   59.34%           
========================================
  Files           16       16           
  Lines         8282     8282           
========================================
  Hits          4915     4915           
  Misses        3367     3367           
Flag Coverage Δ
python-3.13 59.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ptr727 and others added 2 commits October 9, 2026 00:23
Merge Gate item 3 now says `pr_review.py status` and `wait` do not read
the pull request's body, so the gate reads the body live for its
remaining-findings list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Correction to #2631 (comment): that reply retyped the fixing commit's SHA by hand and named a commit that does not exist. The finding ("Make the gate read body-listed findings") is Fixed in 431de37. Merge Gate item 3's body-listed paragraph now says pr_review.py status and wait do not read the pull request's body, so the body is read live for that list before judging the item, the mandatory body-list check the finding offered as its second remedy.

@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 40e11b802422255157975cb06a0fc0e33aa2a2ae, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@ptr727

ptr727 commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Answering the finding the Copilot round on 68e2a43 named only in its file table (1), outside its two threads:

  1. .agents/skills/drive-pr/SKILL.md, "Nit: define the body block format and preservation behavior (1 vote)". No change needed. The format is the one local-strict-review "Disposing of Findings" already sets, which step 2 cites: "The pull request's body lists each remaining finding with its class." Preservation is stated in step 2 itself: "A later push adds its own to any list already there." A fixed heading or markup would be a new contract nothing reads, since pr_review.py status and wait do not read the body and Merge Gate item 3 has the gate read it live instead.

@ptr727
ptr727 merged commit f10164a into develop Oct 9, 2026
13 checks passed
@ptr727
ptr727 deleted the feature/auto-2613 branch October 9, 2026 07:34
ptr727 added a commit that referenced this pull request Oct 9, 2026
Promotes the one change develop holds over main: `drive-pr` writes a
spent edit budget's remaining `introduced` findings into the pull
request body, `pr-review-conduct`'s Merge Gate gives each body-listed
finding an outcome answered as a suppressed finding, and that section
gains `Deferred to <issue>` and `Awaiting maintainer` verdicts (#2631).

Fixes #2613

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants