Repository navigation
Conversation
read() set signature_file to 'Text', while write() sets 'text', the
value that MATLAB Pulseq documents ('text' or 'bin'). So the value for
the same .seq file depended on whether the sequence was written or read.
Add a check to test_writeread that signature_type and signature_file are
the same after write() and after read().
Closes pulseq#427
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mdtisdall
added a commit
to mdtisdall/pypulseq-issues
that referenced
this pull request
Oct 5, 2026
10b was submitted as pulseq/pypulseq#427, and its fix as PR pulseq/pypulseq#428 from the branch fix-signature-file-case in the fork mdtisdall/pypulseq. The README table has the status, the fix branch and the upstream links of 10b, and 10b's pr.md is the text as submitted. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #427
readsetsignature_fileto'Text', whilewritesets'text'. This changesreadto'text', as pulseq/pulseq#296 does for MATLAB Pulseq.signature_file = 'text'inSequence/read_seq.pytest_writeread(tests/test_sequence.py) thatsignature_typeandsignature_fileare the same afterwriteand afterreadThis bug was identified and the test was generated using Claude, but I have reviewed the code and it seems correct to me.