Skip to content

Set signature_file to 'text' in read, as write does #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdtisdall wants to merge 4 commits into
base: master
Choose a base branch
from
+5 −1
Open

Set signature_file to 'text' in read, as write does #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56188a3
Set signature_file to 'text' in read, as write does
mdtisdall Oct 5, 2026
3a67a40
Merge branch 'master' into fix-signature-file-case
schuenke Oct 9, 2026
4b336f6
Merge branch 'master' into fix-signature-file-case
mcencini Oct 29, 2026
f47a13a
Merge branch 'master' into fix-signature-file-case
mcencini Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pypulseq/Sequence/read_seq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def read(self, path: str, detect_rf_use: Union[bool, None] = None, remove_duplic
self.signature_type = temp_sign_defs['Type']
if 'Hash' in temp_sign_defs:
self.signature_value = temp_sign_defs['Hash']
self.signature_file = 'Text'
self.signature_file = 'text'
elif section == '[VERSION]':
file_version_major, file_version_minor, file_version_revision = __read_version(input_file)
file_version_combined = 1000000 * file_version_major + 1000 * file_version_minor + file_version_revision
Expand Down
4 changes: 4 additions & 0 deletions tests/test_sequence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,10 @@ def test_writeread(self, seq_func, tmp_path, compare_seq_file):
# Clean up written sequence file
output_filename.unlink()

# Test that the signature is described in the same way after write and after read
assert seq.signature_file == 'text'
assert (seq2.signature_type, seq2.signature_file) == (seq.signature_type, seq.signature_file)

# Test for approximate equality of all blocks
assert list(seq2.block_events.keys()) == list(seq.block_events.keys()), 'Sequence block IDs are not identical'
for block_counter in seq.block_events:
Expand Down
Loading