Repository navigation
Conversation
androidx.sqlite.bundled now sits only in appleMain. The Android module excludes androidx.sqlite:sqlite-bundled and androidx.sqlite:sqlite-bundled-android from shared-storage-android, so libsqliteJni.so is left out of the packaged app. A patch changeset records that the unused bundled SQLite JNI library is no longer shipped on Android. Fixes react-native-async-storage#1327
1 of 5 tasks
🦋 Changeset detectedLatest commit: 0b40cc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
bundled sqlite is recommended when using room, for consistency across platforms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
androidx.sqlite.bundled now sits only in appleMain. The Android module excludes androidx.sqlite:sqlite-bundled and androidx.sqlite:sqlite-bundled-android from shared-storage-android, so libsqliteJni.so is left out of the packaged app. A patch changeset records that the unused bundled SQLite JNI library is no longer shipped on Android.
Android apps that include Async Storage are flagged in Play Console as liable to crash on 16 KB page-size devices. The report names base/lib/arm64-v8a/libsqliteJni.so and base/lib/x86_64/libsqliteJni.so as libraries built with an older NDK. shared-storage declared androidx.sqlite.bundled in commonMain, so the Android variant also resolved androidx.sqlite:sqlite-bundled and sqlite-bundled-android, the artifacts that ship libsqliteJni.so. Async Storage’s Android build exposes shared-storage-android as an api dependency, so that native library is packaged into the app. The bundled driver is only required on Apple.
Fixes #1327
Test Plan
Ran
yarn run test:lintlocally on macOS for the async-storage change; it fails the same way on the base branch, so the failure predates this change (it fails the same way on upstream/main).yarn run test:lint stopped before linting because the Yarn install state was missing.