Skip to content

fix: stop packaging libsqliteJni.so into Android apps #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvanhorn wants to merge 1 commit into from
Closed

fix: stop packaging libsqliteJni.so into Android apps #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/android-16kb-sqlite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-native-async-storage/async-storage": patch
---

Stop packaging the unused bundled SQLite JNI library into Android apps. That library triggered the 16 KB page-size Play Console warning.
5 changes: 4 additions & 1 deletion packages/async-storage/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ repositories {
dependencies {
def shared_storage_version = project.ext.AsyncStorage.sharedStorageVersion
implementation "com.facebook.react:react-android"
api "io.github.react-native-async-storage:shared-storage-android:$shared_storage_version"
api("io.github.react-native-async-storage:shared-storage-android:$shared_storage_version") {
exclude group: "androidx.sqlite", module: "sqlite-bundled"
exclude group: "androidx.sqlite", module: "sqlite-bundled-android"
}


// ksp/room is required to support legacy storage
Expand Down
7 changes: 5 additions & 2 deletions shared-storage/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,18 @@ kotlin {
commonMain {
dependencies {
implementation(libs.androidx.room.runtime)
implementation(libs.androidx.sqlite.bundled)
implementation(libs.kotlinx.coroutines)
implementation(libs.logging.kermit)
}
}

androidMain { dependencies {} }

appleMain { dependencies {} }
appleMain {
dependencies {
implementation(libs.androidx.sqlite.bundled)
}
}

commonTest {
dependencies {
Expand Down