[Php74] Skip non-nullable typed property on IfToNullCoalescingAssignRector - #8387
Merged
TomasVotruba merged 1 commit intoAug 27, 2026
Merged
Conversation
TomasVotruba
marked this pull request as ready for review
August 27, 2026 10:24
TomasVotruba
deleted the
fix-null-coalescing-assign-non-nullable-property
branch
August 27, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IfToNullCoalescingAssignRectorrewrites a null guardifinto??=without checking the target is nullable. When the target is a typed non-nullable property, the??=left side can never be null, so PHPStan flags it:Before (rule fires, produces invalid code)
Fix
Skip when the guarded target is a
PropertyFetch/StaticPropertyFetchwith a declared non-nullable type. Untyped properties (MixedType) still convert as before.After