Fix TOOLS_JAVA_VERSION export in Dockerfile#296
Open
bact wants to merge 1 commit into
Open
Conversation
Also remove the no-ops $PWD Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
@kzantow please help verify at your convenience. thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So in our case,
TOOLS_JAVA_VERSIONis lost and breaks the@@VERSION@@substitution for thescripts/tools-java-wrapper.sh-- producingtools-java--jar-with-dependencies.jar(missing version, double dash), causing error.source=$PWDon the bind mount.$PWD is not a recognized variable in Dockerfile, always empty.
(No change in behavior, as default is the build context root. Just a cleanup to avoid confusion)
To fix #295