Add smoke test to Docker publish workflow#298
Merged
Conversation
docker_push step needs successful smoke_test Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Collaborator
Author
|
The workflow failed as expected, error messages from the run log confirms #295 as reported by @kzantow:
That error should be fixed once #296 (Dockerfile fix) is merged. -- We should merge #296 first and re-run the CI in this PR again |
Member
|
I merged #296 and reran the CI. It failed with the message: |
Collaborator
Author
|
@goneall the CI is now passing. |
goneall
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@@VERSION@@substitution in tools-java wrapper is success.docker run --rm tools-java:ci-test Versionto test iftools-javais workingdocker_pushstep needs successfulsmoke_testto prevent case like Images after 2.0.4 no longer work #295type=raw,value=maintag rule atmeta_basestepgithub.refis neverrefs/heads/mainhere since push only triggers on tags (not branches) and the repo's default branch ismaster, notmain(we don't havemain).Will close #297