Repository navigation
edit: skip values in HasKey - #453
Merged
Merged
Conversation
HasKey read each key but not the value after it, so on the next pass it read the value as a key. A key after the first was missed and a string value matched as a key. Skip the value as locate and locateKV do.
klauspost
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasKey(msgp/edit.go:55-72) reads each map key withReadStringZCbut never skips the value after it, so the next iteration reads that value as a key.locateandlocateKVcallSkip(bts)after a non-matching key;HasKeydoes not.For
{"thing_one":"value_one","thing_two":2.0,"thing_three":{...}}:Locatefinds itHasKey("thing_one", raw)HasKey("thing_three", raw)HasKey("value_one", raw)The existing
TestLocateonly checksHasKeyfor the first key.TestHasKeycovers first, middle and last keys, a string value, a key inside the nested map and a missing key; it fails on master and passes here.go test ./msgp,go vet,gofmtand the edit tests underGOARCH=386pass on Go 1.26; I did not run./_generatedor Go 1.24/1.25.Written with AI assistance (Claude); I have reviewed the change.