Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions msgp/edit.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ func HasKey(key string, raw []byte) bool {
if UnsafeString(field) == key {
return true
}
bts, err = Skip(bts)
if err != nil {
return false
}
}
return false
}
Expand Down
26 changes: 26 additions & 0 deletions msgp/edit_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,32 @@ func TestLocate(t *testing.T) {
}
}

func TestHasKey(t *testing.T) {
var buf bytes.Buffer
en := NewWriter(&buf)
en.WriteMapHeader(3)
en.WriteString("thing_one")
en.WriteString("value_one")
en.WriteString("thing_two")
en.WriteFloat64(2.0)
en.WriteString("thing_three")
en.WriteMapHeader(1)
en.WriteString("nested")
en.WriteInt(1)
en.Flush()

for _, key := range []string{"thing_one", "thing_two", "thing_three"} {
if !HasKey(key, buf.Bytes()) {
t.Errorf("HasKey(%q) = false; want true", key)
}
}
for _, key := range []string{"value_one", "nested", "nope"} {
if HasKey(key, buf.Bytes()) {
t.Errorf("HasKey(%q) = true; want false", key)
}
}
}

func TestReplace(t *testing.T) {
// there are 4 cases that need coverage:
// - new value is smaller than old value
Expand Down
Loading